Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-18 at 11:05 +, Jan Beulich wrote: > >>> On 18.02.15 at 11:58, wrote: > > On Wed, 2015-02-11 at 07:50 +, Jan Beulich wrote: > >> Quite likely the (mis-)use of these > >> two functions may then temporarily result in messages not meant > >> to be debugging ones to become hidd

Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-18 Thread Jan Beulich
>>> On 18.02.15 at 11:58, wrote: > On Wed, 2015-02-11 at 07:50 +, Jan Beulich wrote: >> Quite likely the (mis-)use of these >> two functions may then temporarily result in messages not meant >> to be debugging ones to become hidden in non-debug builds. If >> others agree, I'd try to make one

Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-18 Thread Ian Campbell
On Wed, 2015-02-11 at 07:50 +, Jan Beulich wrote: > All, > > I'd like to propose to honor the 'd' in these functions' names (which > I understand to mean "debug") in that such functions should be > no-ops in non-debug builds. I'd then be inclined to introduce a > gprintk() automatically adding

Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-11 Thread Andrew Cooper
On 11/02/15 10:32, Jan Beulich wrote: On 11.02.15 at 11:05, wrote: >> On 11/02/15 07:50, Jan Beulich wrote: >>> I'd like to propose to honor the 'd' in these functions' names (which >>> I understand to mean "debug") in that such functions should be >>> no-ops in non-debug builds. I'd then be

Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-11 Thread Jan Beulich
>>> On 11.02.15 at 11:05, wrote: > On 11/02/15 07:50, Jan Beulich wrote: >> I'd like to propose to honor the 'd' in these functions' names (which >> I understand to mean "debug") in that such functions should be >> no-ops in non-debug builds. I'd then be inclined to introduce a >> gprintk() automa

Re: [Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-11 Thread Andrew Cooper
On 11/02/15 07:50, Jan Beulich wrote: > All, > > I'd like to propose to honor the 'd' in these functions' names (which > I understand to mean "debug") in that such functions should be > no-ops in non-debug builds. I'd then be inclined to introduce a > gprintk() automatically adding XENLOG_GUEST and

[Xen-devel] dprintk() and gdprintk() to be compiled out when NDEBUG

2015-02-10 Thread Jan Beulich
All, I'd like to propose to honor the 'd' in these functions' names (which I understand to mean "debug") in that such functions should be no-ops in non-debug builds. I'd then be inclined to introduce a gprintk() automatically adding XENLOG_GUEST and the printing of current using the %pv format. Qu