Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread George Dunlap
On Thu, Jul 23, 2015 at 12:01 AM, Ed White wrote: > +int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx) > +{ > +struct p2m_domain *p2m; > +int rc = -EINVAL; > + > +if ( !idx || idx > MAX_ALTP2M ) > +return rc; > + > +domain_pause_except_self(d); > + > +alt

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 23, 2015 9:16 AM > On 23.07.15 at 18:08, wrote: >> On 07/23/2015 03:51 PM, Sahita, Ravi wrote: > +int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx) { > +struct p2m_domain *p2m; > +int rc = -

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 18:08, wrote: > On 07/23/2015 03:51 PM, Sahita, Ravi wrote: +int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx) { +struct p2m_domain *p2m; +int rc = -EINVAL; + +if ( !idx || idx > MAX_ALTP2M ) >>> >>> >= (and then also elsew

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread George Dunlap
On 07/23/2015 03:51 PM, Sahita, Ravi wrote: >>> +int p2m_destroy_altp2m_by_id(struct domain *d, unsigned int idx) { >>> +struct p2m_domain *p2m; >>> +int rc = -EINVAL; >>> + >>> +if ( !idx || idx > MAX_ALTP2M ) >> >> >= (and then also elsewhere further down)? >> > > Right. [snip]

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 16:51, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >>Sent: Thursday, July 23, 2015 3:06 AM > On 23.07.15 at 01:01, wrote: >>> @@ -758,6 +765,38 @@ bool_t p2m_switch_vcpu_altp2m_by_id(struct >>vcpu >>> *v, unsigned int idx); >>> /* Check to see if vcpu should be

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 23, 2015 3:06 AM > On 23.07.15 at 01:01, wrote: >> Add the remaining routines required to support enabling the alternate >> p2m functionality. >> >> Signed-off-by: Ed White >> >> Reviewed-by: Andrew Cooper >> --- >> Changes

Re: [Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-23 Thread Jan Beulich
>>> On 23.07.15 at 01:01, wrote: > Add the remaining routines required to support enabling the alternate > p2m functionality. > > Signed-off-by: Ed White > > Reviewed-by: Andrew Cooper > --- > Changes since v6: > rename altp2m lazy copier, make bool_t, use __put_gfn throughout, >

[Xen-devel] [PATCH v7 10/15] x86/altp2m: add remaining support routines.

2015-07-22 Thread Ed White
Add the remaining routines required to support enabling the alternate p2m functionality. Signed-off-by: Ed White Reviewed-by: Andrew Cooper --- Changes since v6: rename altp2m lazy copier, make bool_t, use __put_gfn throughout, and move to p2m.c, eliminating altp2m_hap.c