Re: [Xen-devel] [PATCH v6 06/31] xen/arm: ITS: Port ITS driver to Xen

2015-09-03 Thread Julien Grall
On 31/08/15 12:06, vijay.kil...@gmail.com wrote: > +struct its_device { > +/* Physical ITS */ > +struct its_node *its; > +/* Device ITT address */ > +paddr_t *itt_addr; Just spotted this, why do you have a pointer to paddr_t? You store a pointer to the base

Re: [Xen-devel] [PATCH v6 06/31] xen/arm: ITS: Port ITS driver to Xen

2015-08-31 Thread Julien Grall
Hi Vijay, This patch now looks good. A few comments below. First, I've noticed that you moved again its_send_inv into patch #13. On a previous version (v4) we asked you to keep all the code imported by Linux in a single patch. You moved it correctly in v5 but then moved again out in this vers

[Xen-devel] [PATCH v6 06/31] xen/arm: ITS: Port ITS driver to Xen

2015-08-31 Thread vijay . kilari
From: Vijaya Kumar K The linux driver is based on 4.1 with below commit id 3ad2a5f57656a14d964b673a5a0e4ab0e583c870 Only following code from Linux ITS driver is ported and compiled - LPI initialization - ITS configuration code - Physical command queue management - ITS command building Also