Re: [Xen-devel] [PATCH v5 1/6] build: convert debug to Kconfig

2016-06-08 Thread Doug Goldstein
On 6/8/16 12:53 PM, Julien Grall wrote: > Hi Doug, > > On 24/05/16 14:56, Doug Goldstein wrote: >> diff --git a/xen/Rules.mk b/xen/Rules.mk >> index 961d533..da2f490 100644 >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -20,13 +20,14 @@ include $(XEN_ROOT)/Config.mk >> ifeq ($(debug),y) >>

Re: [Xen-devel] [PATCH v5 1/6] build: convert debug to Kconfig

2016-06-08 Thread Julien Grall
Hi Doug, On 24/05/16 14:56, Doug Goldstein wrote: diff --git a/xen/Rules.mk b/xen/Rules.mk index 961d533..da2f490 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -20,13 +20,14 @@ include $(XEN_ROOT)/Config.mk ifeq ($(debug),y) verbose := y frame_pointer := y -else -CFLAGS += -DNDEBUG

Re: [Xen-devel] [PATCH v5 1/6] build: convert debug to Kconfig

2016-05-24 Thread Jan Beulich
>>> On 24.05.16 at 15:56, wrote: > Enabling debug will disable NDEBUG which will result in more debug > prints. There are a number of debugging options for Xen so place the > debug option under a menu for different debugging options to have a way > to group them all together. > > Signed-off-by:

[Xen-devel] [PATCH v5 1/6] build: convert debug to Kconfig

2016-05-24 Thread Doug Goldstein
Enabling debug will disable NDEBUG which will result in more debug prints. There are a number of debugging options for Xen so place the debug option under a menu for different debugging options to have a way to group them all together. Signed-off-by: Doug Goldstein Reviewed-by: Andrew Cooper Re