Hi Doug,
On 24/05/16 14:56, Doug Goldstein wrote:
diff --git a/xen/Rules.mk b/xen/Rules.mk
index 961d533..da2f490 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -20,13 +20,14 @@ include $(XEN_ROOT)/Config.mk
ifeq ($(debug),y)
verbose := y
frame_pointer := y
-else
-CFLAGS += -DNDEBUG
endif
ifeq ($(perfc_arrays),y)
perfc := y
endif
+ifeq ($(origin debug),command line)
+$(warning "You must use 'make menuconfig' to enable/disable debug now.")
While building Xen with "debug=.." on the command Line, I got the
warning because I have to use Kconfig now. This warning is lost among
compilation logs.
As this is a warning, I would expect debug=... to work as previously.
However debug= is just ignored. So I think we should replace the warning
by an error to avoiding people spending time to understanding why debug
has not been enabled.
Any opinions?
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
