Re: [Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-09-07 Thread Wei Liu
On Wed, Sep 06, 2017 at 06:53:19PM +0300, Oleksandr Grytsov wrote: > So I guess the right place for these changes will be > first patch where changes to devtype are introduced. > I will fix setdefault function parameters for all devtypes. > Does it sounds good? Yes. __

Re: [Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-09-06 Thread Oleksandr Grytsov
On Tue, Sep 5, 2017 at 4:06 PM, Wei Liu wrote: > On Tue, Jul 18, 2017 at 05:25:30PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov >> >> Due to changes in device framework setdefault function >> should have same format. Otherwise calling devicetype >> set_default causes segfault. >> >

Re: [Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-09-05 Thread Wei Liu
On Tue, Jul 18, 2017 at 05:25:30PM +0300, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov > > Due to changes in device framework setdefault function > should have same format. Otherwise calling devicetype > set_default causes segfault. > > Signed-off-by: Oleksandr Grytsov Shouldn't this pat

[Xen-devel] [PATCH v4 13/13] libxl: make pci and usb setdefault function generic

2017-07-18 Thread Oleksandr Grytsov
From: Oleksandr Grytsov Due to changes in device framework setdefault function should have same format. Otherwise calling devicetype set_default causes segfault. Signed-off-by: Oleksandr Grytsov --- tools/libxl/libxl_internal.h | 1 - tools/libxl/libxl_pci.c | 5 +++-- tools/libxl/libxl_u