On Tue, Sep 5, 2017 at 4:06 PM, Wei Liu <wei.l...@citrix.com> wrote: > On Tue, Jul 18, 2017 at 05:25:30PM +0300, Oleksandr Grytsov wrote: >> From: Oleksandr Grytsov <oleksandr_gryt...@epam.com> >> >> Due to changes in device framework setdefault function >> should have same format. Otherwise calling devicetype >> set_default causes segfault. >> >> Signed-off-by: Oleksandr Grytsov <oleksandr_gryt...@epam.com> > > Shouldn't this patch be placed before the introduction of the new > framework?
Wrong function parameters will cause crash if devtype framework will be used. For example if someone call pci set_default: libxl__nic_devtype.set_default(...) So I guess the right place for these changes will be first patch where changes to devtype are introduced. I will fix setdefault function parameters for all devtypes. Does it sounds good? -- Best Regards, Oleksandr Grytsov. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
