Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-24 Thread Jan Beulich
>>> On 24.05.16 at 03:03, wrote: > On 5/23/16 7:58 AM, Jan Beulich wrote: > On 22.05.16 at 07:01, wrote: > >>> verbose := y >>> frame_pointer := y >>> -else >>> -CFLAGS += -DNDEBUG >>> endif >>> ifeq ($(perfc_arrays),y) >>> perfc := y >>> endif >>> >>> +ifeq ($(origin debug),co

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-23 Thread Doug Goldstein
On 5/23/16 3:39 AM, Jan Beulich wrote: On 22.05.16 at 21:04, wrote: >> On 5/22/16 12:01 AM, Doug Goldstein wrote: >>> --- /dev/null >>> +++ b/xen/Kconfig.debug >>> @@ -0,0 +1,13 @@ >>> + >>> +menu "Debugging Options" >>> + >>> +config DEBUG >>> + bool "Developer Checks" >> >> Add the follow

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-23 Thread Doug Goldstein
On 5/23/16 8:19 AM, Andrew Cooper wrote: > On 23/05/16 13:58, Jan Beulich wrote: > On 22.05.16 at 07:01, wrote: >>> --- /dev/null >>> +++ b/xen/Kconfig.debug >>> @@ -0,0 +1,13 @@ >>> + >>> +menu "Debugging Options" >>> + >>> +config DEBUG >>> + bool "Developer Checks" >>> + ---help--- >>>

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-23 Thread Doug Goldstein
On 5/23/16 7:58 AM, Jan Beulich wrote: On 22.05.16 at 07:01, wrote: >> verbose := y >> frame_pointer := y >> -else >> -CFLAGS += -DNDEBUG >> endif >> ifeq ($(perfc_arrays),y) >> perfc := y >> endif >> >> +ifeq ($(origin debug),command line) >> +$(error "You must use 'make menuc

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-23 Thread Andrew Cooper
On 23/05/16 13:58, Jan Beulich wrote: On 22.05.16 at 07:01, wrote: >> --- /dev/null >> +++ b/xen/Kconfig.debug >> @@ -0,0 +1,13 @@ >> + >> +menu "Debugging Options" >> + >> +config DEBUG >> +bool "Developer Checks" >> +---help--- >> + Enables developer checks such as asserts and

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-23 Thread Jan Beulich
>>> On 22.05.16 at 07:01, wrote: > --- /dev/null > +++ b/xen/Kconfig.debug > @@ -0,0 +1,13 @@ > + > +menu "Debugging Options" > + > +config DEBUG > + bool "Developer Checks" > + ---help--- > + Enables developer checks such as asserts and extra printks, this > + option is intend

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-23 Thread Jan Beulich
>>> On 22.05.16 at 21:04, wrote: > On 5/22/16 12:01 AM, Doug Goldstein wrote: >> --- /dev/null >> +++ b/xen/Kconfig.debug >> @@ -0,0 +1,13 @@ >> + >> +menu "Debugging Options" >> + >> +config DEBUG >> +bool "Developer Checks" > > Add the following when committing: > > default y > > if

Re: [Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-22 Thread Doug Goldstein
On 5/22/16 12:01 AM, Doug Goldstein wrote: > Enabling debug will disable NDEBUG which will result in more debug > prints. There are a number of debugging options for Xen so place the > debug option under a menu for different debugging options to have a way > to group them all together. > > Signed

[Xen-devel] [PATCH v4 1/6] build: convert debug to Kconfig

2016-05-21 Thread Doug Goldstein
Enabling debug will disable NDEBUG which will result in more debug prints. There are a number of debugging options for Xen so place the debug option under a menu for different debugging options to have a way to group them all together. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: Geo