On Thu, Mar 26, Ian Campbell wrote:
> On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote:
> > On Fri, Mar 13, Ian Campbell wrote:
> > > Also, should this be a defbool or not?
> > This is a good idea. I remmeber xend had code to make sure that all
> > devices within a vhost had the same value for
On Thu, 2015-03-26 at 13:55 +0100, Olaf Hering wrote:
> On Fri, Mar 13, Ian Campbell wrote:
>
> > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > > > > > +("feature_host", bool),
> > > > > > What is this feature thing? What does !host imply?
> > > > > This enables raw S
On Fri, Mar 13, Ian Campbell wrote:
> > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > > > > +("feature_host", bool),
> > > > > What is this feature thing? What does !host imply?
> > > > This enables raw SCSI command passthrough in xenlinux. If the flag is
> > > > off th
On Mon, Mar 16, 2015 at 09:16:31AM +0100, Olaf Hering wrote:
> On Fri, Mar 13, Wei Liu wrote:
>
> > On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote:
> > > On Thu, Mar 12, Ian Campbell wrote:
> > >
> > > > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote:
> > > > > Related: I see l
On Fri, Mar 13, Wei Liu wrote:
> On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote:
> > On Thu, Mar 12, Ian Campbell wrote:
> >
> > > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote:
> > > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I
> > > > assume its
On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote:
> On Thu, Mar 12, Ian Campbell wrote:
>
> > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote:
> > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I
> > > assume its required to validate input in libxl_device_
On Fri, 2015-03-13 at 14:44 +0100, Olaf Hering wrote:
> On Thu, Mar 12, Ian Campbell wrote:
>
> > On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote:
> > > On Wed, Mar 11, Ian Campbell wrote:
> > >
> > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > > > +int libxl_device_vscsi_p
On Thu, Mar 12, Ian Campbell wrote:
> On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote:
> > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I
> > assume its required to validate input in libxl_device_vscsi_get_host.
> Not sure what you mean, you should call libxl_device_
On Wed, Mar 11, Ian Campbell wrote:
> On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote:
> > On Wed, Mar 11, Ian Campbell wrote:
> >
> > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi
> > > > *hst,
> > > >
On Thu, Mar 12, Ian Campbell wrote:
> On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote:
> > On Wed, Mar 11, Ian Campbell wrote:
> >
> > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > > +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned
> > > > int *hst,
> >
On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote:
> On Wed, Mar 11, Ian Campbell wrote:
>
> > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi
> > > *hst,
> > > + libxl_vscsi_de
On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote:
> On Wed, Mar 11, Ian Campbell wrote:
>
> > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned
> > > int *hst,
> > > +unsigned int
On Wed, Mar 11, Ian Campbell wrote:
> On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned int
> > *hst,
> > +unsigned int *chn, unsigned int *tgt,
> > +unsi
On Wed, Mar 11, Ian Campbell wrote:
> On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > + libxl_vscsi_dev *dev);
> > +int libxl_device_vscsi_get_host(libxl_ctx *ctx,
> > +
On Wed, Mar 11, Ian Campbell wrote:
> On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > + libxl_vscsi_dev *dev);
> > +int libxl_device_vscsi_get_host(libxl_ctx *ctx,
> > +
On Wed, Mar 11, Ian Campbell wrote:
> On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > + libxl_vscsi_dev *dev);
> > +int libxl_device_vscsi_get_host(libxl_ctx *ctx,
> > +
On Fri, 2015-03-06 at 14:31 +, Wei Liu wrote:
> > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi *hst,
> > + libxl_vscsi_dev *dev)
> > +{
>
> Can this only be an internal function? I.e. use libxl__ namespace.
And take a libxl__gc *gc n
On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote:
> On Wed, Mar 11, Ian Campbell wrote:
>
> > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi
> > > *hst,
> > > + libxl_vscsi_de
On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote:
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 6bbc52d..1ad52e3 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
Needs a LIBXL_HAVE define too.
> @@ -1224,6 +1224,35 @@ int libxl_device_channel_getinfo(libxl_ctx
On Mon, Mar 09, 2015 at 05:08:31PM +0100, Olaf Hering wrote:
> On Fri, Mar 06, Wei Liu wrote:
>
> > > +void libxl__device_vscsi_add(libxl__egc *egc, uint32_t domid,
> > > + libxl_device_vscsi *vscsi,
> > > + libxl__ao_device *aodev)
> > You n
On Fri, Mar 06, Wei Liu wrote:
> > +void libxl__device_vscsi_add(libxl__egc *egc, uint32_t domid,
> > + libxl_device_vscsi *vscsi,
> > + libxl__ao_device *aodev)
> You need to update this domain's JSON configuration. Cf.
> libxl__device_vtpm_
On Fri, Mar 06, 2015 at 04:25:54PM +0100, Olaf Hering wrote:
> On Fri, Mar 06, Wei Liu wrote:
>
> > I think you need to fix some overly long lines. I won't mention them
> > individually inline.
>
> Some are just copy&paste from other places. I will check what can be
> trimmed.
>
> > Regarding al
On Fri, Mar 06, Wei Liu wrote:
> I think you need to fix some overly long lines. I won't mention them
> individually inline.
Some are just copy&paste from other places. I will check what can be
trimmed.
> Regarding all the parsing stuffs, you haven't defined vscsispec so I
> cannot review it. Yo
This is a very big patch, I've only skimmed it so far.
I think you need to fix some overly long lines. I won't mention them
individually inline.
Regarding all the parsing stuffs, you haven't defined vscsispec so I
cannot review it. You might want to look at
docs/misc/xl-disk-configuration.txt.
I
Port pvscsi support from xend to libxl. See pvscsi.txt for details.
Outstanding work is listed in the TODO section.
Signed-off-by: Olaf Hering
Cc: Ian Jackson
Cc: Stefano Stabellini
Cc: Ian Campbell
Cc: Wei Liu
---
tools/libxl/Makefile | 1 +
tools/libxl/libxl.c
25 matches
Mail list logo
