Re: [Xen-devel] [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union

2016-12-01 Thread Jan Beulich
>>> On 30.11.16 at 14:50, wrote: > Rename byte to raw, as the field being a single byte long is an implementation > detail. Make the bitfields part of an anonymous struct to remove the .flags > qualifier. Change the types of the flags to being booleans, to match their > use. With that you shoul

Re: [Xen-devel] [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union

2016-11-30 Thread Jan Beulich
>>> On 30.11.16 at 15:05, wrote: >> From: Andrew Cooper >> Sent: 30 November 2016 14:02 >> On 30/11/16 13:58, Paul Durrant wrote: >> > Also, anonymous unions are not part of C99 AFAIK... are we now stipulating >> something more recent? >> >> We used gnu99 for as long as I can remember, and we hav

Re: [Xen-devel] [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union

2016-11-30 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 30 November 2016 14:02 > To: Paul Durrant ; Xen-devel de...@lists.xen.org> > Cc: Jan Beulich > Subject: Re: [PATCH v3 07/24] x86/emul: Clean up the naming of the retire > union > > On 30/11/16 13:58, Paul Durrant wrote: > >> -Origina

Re: [Xen-devel] [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union

2016-11-30 Thread Andrew Cooper
On 30/11/16 13:58, Paul Durrant wrote: >> -Original Message- >> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] >> Sent: 30 November 2016 13:50 >> To: Xen-devel >> Cc: Andrew Cooper ; Jan Beulich >> ; Paul Durrant >> Subject: [PATCH v3 07/24] x86/emul: Clean up the naming of the re

Re: [Xen-devel] [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union

2016-11-30 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 30 November 2016 13:50 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Paul Durrant > Subject: [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union > > Rename byte to raw, as the fie

[Xen-devel] [PATCH v3 07/24] x86/emul: Clean up the naming of the retire union

2016-11-30 Thread Andrew Cooper
Rename byte to raw, as the field being a single byte long is an implementation detail. Make the bitfields part of an anonymous struct to remove the .flags qualifier. Change the types of the flags to being booleans, to match their use. No functional change. Signed-off-by: Andrew Cooper --- CC: