Re: [Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

2016-04-05 Thread Joao Martins
On 04/05/2016 04:26 PM, Jan Beulich wrote: On 05.04.16 at 17:22, wrote: >> On 04/05/2016 12:52 PM, Jan Beulich wrote: >> On 29.03.16 at 15:44, wrote: -static s_time_t read_platform_stime(void) +static s_time_t read_platform_stime(u64 *stamp) { -u64 count;

Re: [Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

2016-04-05 Thread Jan Beulich
>>> On 05.04.16 at 17:22, wrote: > On 04/05/2016 12:52 PM, Jan Beulich wrote: > On 29.03.16 at 15:44, wrote: >>> -static s_time_t read_platform_stime(void) >>> +static s_time_t read_platform_stime(u64 *stamp) >>> { >>> -u64 count; >>> +u64 plt_stamp_counter, count; >> >> "stamp" and

Re: [Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

2016-04-05 Thread Joao Martins
On 04/05/2016 12:52 PM, Jan Beulich wrote: On 29.03.16 at 15:44, wrote: >> -static s_time_t read_platform_stime(void) >> +static s_time_t read_platform_stime(u64 *stamp) >> { >> -u64 count; >> +u64 plt_stamp_counter, count; > > "stamp" and "counter" seem kind of redundant. > A bi

Re: [Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

2016-04-05 Thread Jan Beulich
>>> On 29.03.16 at 15:44, wrote: > -static s_time_t read_platform_stime(void) > +static s_time_t read_platform_stime(u64 *stamp) > { > -u64 count; > +u64 plt_stamp_counter, count; "stamp" and "counter" seem kind of redundant. > s_time_t stime; > > ASSERT(!local_irq_is_enable

Re: [Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

2016-04-01 Thread Konrad Rzeszutek Wilk
On Tue, Mar 29, 2016 at 02:44:10PM +0100, Joao Martins wrote: > To fetch the last read from the clocksource which was used to > calculate system_time. In the case of clocksource=tsc we will > use it to set tsc_timestamp. > > Signed-off-by: Joao Martins > Reviewed-by: Andrew Cooper Reviewed-by:

[Xen-devel] [PATCH v2 5/6] x86/time: refactor read_platform_stime()

2016-03-29 Thread Joao Martins
To fetch the last read from the clocksource which was used to calculate system_time. In the case of clocksource=tsc we will use it to set tsc_timestamp. Signed-off-by: Joao Martins Reviewed-by: Andrew Cooper --- Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper Changes since v1: - Add missi