Re: [Xen-devel] [PATCH v2 3/9] tmem: Delete deduplication (and tze) code.

2016-09-30 Thread Andrew Cooper
On 30/09/16 19:11, Konrad Rzeszutek Wilk wrote: > Couple of reasons: > - It can lead to security issues (see row-hammer, KSM and such >attacks). > - Code is quite complex. > - Deduplication is good if the pages themselves are the same >but that is hardly guaranteed. > - We got some gain

[Xen-devel] [PATCH v2 3/9] tmem: Delete deduplication (and tze) code.

2016-09-30 Thread Konrad Rzeszutek Wilk
Couple of reasons: - It can lead to security issues (see row-hammer, KSM and such attacks). - Code is quite complex. - Deduplication is good if the pages themselves are the same but that is hardly guaranteed. - We got some gains (if pages are deduped) but at the cost of making code les