On 30/09/16 19:11, Konrad Rzeszutek Wilk wrote: > Couple of reasons: > - It can lead to security issues (see row-hammer, KSM and such > attacks). > - Code is quite complex. > - Deduplication is good if the pages themselves are the same > but that is hardly guaranteed. > - We got some gains (if pages are deduped) but at the cost of > making code less maintainable. > - tze depends on deduplication code. > > As such, deleting it. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
Acked-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > v1: First submission. > v2: Squash " tmem: Wrap tmem dedup code with CONFIG_TMEM_DEDUP" > and "tmem: Wrap tmem tze code with CONFIG_TMEM_TZE" > --- > docs/misc/xen-command-line.markdown | 6 - > xen/common/tmem.c | 310 > +----------------------------------- > xen/common/tmem_control.c | 7 - > xen/common/tmem_xen.c | 28 ---- > xen/include/xen/tmem_xen.h | 115 ------------- > 5 files changed, 3 insertions(+), 463 deletions(-) <3 this diffstat :) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
