Re: [Xen-devel] [PATCH v2 27/29] ArmVirtualizationPkg: add XenIoMmioLib

2015-02-03 Thread Ard Biesheuvel
On 3 February 2015 at 11:55, Laszlo Ersek wrote: > On 02/03/15 12:45, Laszlo Ersek wrote: >> comments below >> >> On 01/26/15 20:03, Ard Biesheuvel wrote: > >>> +EFI_STATUS >>> +XenIoMmioInstall ( >>> + IN EFI_HANDLE *Handle, >>> + IN UINT64 GrantTableAddress >>> + ) >>> +{ >>> + EFI_S

Re: [Xen-devel] [PATCH v2 27/29] ArmVirtualizationPkg: add XenIoMmioLib

2015-02-03 Thread Laszlo Ersek
On 02/03/15 12:45, Laszlo Ersek wrote: > comments below > > On 01/26/15 20:03, Ard Biesheuvel wrote: >> +EFI_STATUS >> +XenIoMmioInstall ( >> + IN EFI_HANDLE *Handle, >> + IN UINT64 GrantTableAddress >> + ) >> +{ >> + EFI_STATUS Status; >> + XENIO_PROTOCOL

Re: [Xen-devel] [PATCH v2 27/29] ArmVirtualizationPkg: add XenIoMmioLib

2015-02-03 Thread Laszlo Ersek
On 01/26/15 20:03, Ard Biesheuvel wrote: > +EFI_STATUS > +XenIoMmioInstall ( > + IN EFI_HANDLE *Handle, > + IN UINT64 GrantTableAddress > + ); Sorry I had another (pedantic) remark here -- consider EFI_PHYSICAL_ADDRESS instead of UINT64. (It looks better and that's what's in your proto

Re: [Xen-devel] [PATCH v2 27/29] ArmVirtualizationPkg: add XenIoMmioLib

2015-02-03 Thread Laszlo Ersek
comments below On 01/26/15 20:03, Ard Biesheuvel wrote: > This adds a XenIoMmioLib declaration and implementation that can > be invoked to install the XENIO_PROTOCOL and a corresponding > grant table address on a EFI handle. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off

[Xen-devel] [PATCH v2 27/29] ArmVirtualizationPkg: add XenIoMmioLib

2015-01-26 Thread Ard Biesheuvel
This adds a XenIoMmioLib declaration and implementation that can be invoked to install the XENIO_PROTOCOL and a corresponding grant table address on a EFI handle. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmVirtualizationPkg/ArmVirt