Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On Tue, Jul 7, 2015 at 5:27 AM, Jan Beulich wrote: > >>> On 30.06.15 at 16:11, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -6431,6 +6431,17 @@ int hvm_debug_op(struct vcpu *v, int32_t op) > > return rc; > > } > > > > +void hvm_toggle_singlestep(struct vc

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

>>> On 30.06.15 at 16:11, wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -6431,6 +6431,17 @@ int hvm_debug_op(struct vcpu *v, int32_t op) > return rc; > } > > +void hvm_toggle_singlestep(struct vcpu *v) > +{ > +ASSERT(atomic_read(&v->pause_count)); > + > +

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 07/07/2015 09:20 AM, Jan Beulich wrote: On 06.07.15 at 19:03, wrote: >> I don't mind just having the comment for now, so for what it's worth I >> stand by my ack. >> >> Having said that (and with the understading that it is beyond the scope >> of this patch), a way to validate things like

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

>>> On 06.07.15 at 19:03, wrote: > I don't mind just having the comment for now, so for what it's worth I > stand by my ack. > > Having said that (and with the understading that it is beyond the scope > of this patch), a way to validate things like these is a good idea. I > wonder if, in a future

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 06/07/15 18:36, Lengyel, Tamas wrote: > > > On Mon, Jul 6, 2015 at 1:29 PM, Razvan Cojocaru > mailto:rcojoc...@bitdefender.com>> wrote: > > On 07/06/2015 08:17 PM, Andrew Cooper wrote: > > On 06/07/15 18:08, Lengyel, Tamas wrote: > >> > >> Having said that (and with the under

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 06/07/15 18:29, Razvan Cojocaru wrote: > On 07/06/2015 08:17 PM, Andrew Cooper wrote: >> On 06/07/15 18:08, Lengyel, Tamas wrote: >>> Having said that (and with the understading that it is beyond the >>> scope >>> of this patch), a way to validate things like these is a good idea. I

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On Mon, Jul 6, 2015 at 1:29 PM, Razvan Cojocaru wrote: > On 07/06/2015 08:17 PM, Andrew Cooper wrote: > > On 06/07/15 18:08, Lengyel, Tamas wrote: > >> > >> Having said that (and with the understading that it is beyond the > >> scope > >> of this patch), a way to validate things like

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 07/06/2015 08:17 PM, Andrew Cooper wrote: > On 06/07/15 18:08, Lengyel, Tamas wrote: >> >> Having said that (and with the understading that it is beyond the >> scope >> of this patch), a way to validate things like these is a good idea. I >> wonder if, in a future patch, we could

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 06/07/15 18:08, Lengyel, Tamas wrote: > > Having said that (and with the understading that it is beyond the > scope > of this patch), a way to validate things like these is a good idea. I > wonder if, in a future patch, we could not have ./configure detect > these > thing

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

> Having said that (and with the understading that it is beyond the scope > of this patch), a way to validate things like these is a good idea. I > wonder if, in a future patch, we could not have ./configure detect these > things and simply disable the relevant VM_EVENT_FLAG constants with > #if(n)

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 07/06/2015 07:26 PM, Lengyel, Tamas wrote: > > > On Mon, Jul 6, 2015 at 11:54 AM, Jan Beulich > wrote: > > >>> On 06.07.15 at 17:35, > wrote: > > On Mon, Jul 6, 2015 at 11:26 AM, Jan Beulich >

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On Mon, Jul 6, 2015 at 11:54 AM, Jan Beulich wrote: > >>> On 06.07.15 at 17:35, wrote: > > On Mon, Jul 6, 2015 at 11:26 AM, Jan Beulich wrote: > > > >> >>> On 30.06.15 at 16:40, wrote: > >> > On Tue, Jun 30, 2015 at 10:18 AM, Andrew Cooper < > >> andrew.coop...@citrix.com> > >> > wrote: > >> >

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

>>> On 06.07.15 at 17:35, wrote: > On Mon, Jul 6, 2015 at 11:26 AM, Jan Beulich wrote: > >> >>> On 30.06.15 at 16:40, wrote: >> > On Tue, Jun 30, 2015 at 10:18 AM, Andrew Cooper < >> andrew.coop...@citrix.com> >> > wrote: >> > >> >> On 30/06/15 15:11, Tamas K Lengyel wrote: >> >> > diff --git a

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On Mon, Jul 6, 2015 at 11:26 AM, Jan Beulich wrote: > >>> On 30.06.15 at 16:40, wrote: > > On Tue, Jun 30, 2015 at 10:18 AM, Andrew Cooper < > andrew.coop...@citrix.com> > > wrote: > > > >> On 30/06/15 15:11, Tamas K Lengyel wrote: > >> > diff --git a/xen/include/public/vm_event.h > >> b/xen/inc

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

>>> On 30.06.15 at 16:40, wrote: > On Tue, Jun 30, 2015 at 10:18 AM, Andrew Cooper > wrote: > >> On 30/06/15 15:11, Tamas K Lengyel wrote: >> > diff --git a/xen/include/public/vm_event.h >> b/xen/include/public/vm_event.h >> > index 577e971..b8c3dde 100644 >> > --- a/xen/include/public/vm_event.

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On Tue, Jun 30, 2015 at 10:18 AM, Andrew Cooper wrote: > On 30/06/15 15:11, Tamas K Lengyel wrote: > > diff --git a/xen/include/public/vm_event.h > b/xen/include/public/vm_event.h > > index 577e971..b8c3dde 100644 > > --- a/xen/include/public/vm_event.h > > +++ b/xen/include/public/vm_event.h > >

Re: [Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

On 30/06/15 15:11, Tamas K Lengyel wrote: > diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h > index 577e971..b8c3dde 100644 > --- a/xen/include/public/vm_event.h > +++ b/xen/include/public/vm_event.h > @@ -44,9 +44,15 @@ > * paused > * VCPU_PAUSED in a response signa

[Xen-devel] [PATCH v2] x86/vm_event: toggle singlestep from vm_event response

Add an option to the vm_event response to toggle singlestepping on the vCPU. This is only supported on Intel CPUs which have Monitor Trap Flag capability. Singed-off-by: Tamas K Lengyel Acked-by: Razvan Cojocaru --- v2: Include sched.h in headers and sanity check that vcpu is paused. --- MAINTA