>>> On 30.06.15 at 16:11, <tleng...@novetta.com> wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -6431,6 +6431,17 @@ int hvm_debug_op(struct vcpu *v, int32_t op) > return rc; > } > > +void hvm_toggle_singlestep(struct vcpu *v) > +{ > + ASSERT(atomic_read(&v->pause_count)); > + > + /* This feature is only available on Intel CPUs. */ > + if ( !cpu_has_monitor_trap_flag )
I'd be okay with this if the get-capabilities patch then changed it to use hvm_is_singlestep_supported(). And the two patches conflict with one another anyway, so should be put together in a series with this one being 2nd. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel