On Mon, Apr 11, 2016 at 02:57:20PM +0200, Olaf Hering wrote:
> On Fri, Apr 08, Olaf Hering wrote:
>
> > +r = sscanf(be_path,"/local/domain/%d/backend/%15[^/]/%d",
> > + &be_domid, be_type, &fe_domid);
>
> Why are these values parsed as signed integers, and then placed in
> uint3
On Fri, Apr 08, Olaf Hering wrote:
> +r = sscanf(be_path,"/local/domain/%d/backend/%15[^/]/%d",
> + &be_domid, be_type, &fe_domid);
Why are these values parsed as signed integers, and then placed in
uint32? Was this just an oversight during review?
Olaf
___
On Fri, Apr 08, Wei Liu wrote:
> On Fri, Apr 08, 2016 at 04:16:46PM +0200, Olaf Hering wrote:
> > What do you have in mind? Something like in vusb_be_from_xs_fe?
> Yes.
Thanks, I will test this change:
Sanitize input from frontend in vscsi_fill_ctrl
Signed-off-by: Olaf Hering
diff --
On Fri, Apr 08, 2016 at 02:47:14PM +0100, Ian Jackson wrote:
> Wei Liu writes ("Re: [PATCH v11 1/2] libxl: add support for vscsi"):
> > What Ian wanted was that we need clear correlation of xl configuration
> > syntax with libxl API fields. For example, for a FOO device
>
> Thanks for explaining,
On Fri, Apr 08, 2016 at 04:16:46PM +0200, Olaf Hering wrote:
> On Fri, Apr 08, Wei Liu wrote:
>
> > What Ian wanted was that we need clear correlation of xl configuration
> > syntax with libxl API fields. For example, for a FOO device
> >
> >xl.cfg: FOO = [ "bar=baz" ]
> >
> >libxl_types
On Fri, Apr 08, 2016 at 04:16:46PM +0200, Olaf Hering wrote:
> > > +goto out;
> > > +
> > > +tmp = libxl__xs_read(gc, t, GCSPRINTF("%s/%s/backend-id", fe_path,
> > > dir));
> > > +if (!tmp)
> > > +goto out;
> > > +ctrl->backend_domid = atoi(tmp);
> >
> > Please sanitis
On Fri, Apr 08, Wei Liu wrote:
> What Ian wanted was that we need clear correlation of xl configuration
> syntax with libxl API fields. For example, for a FOO device
>
>xl.cfg: FOO = [ "bar=baz" ]
>
>libxl_types.idl:
>
> libxl_device_FOO = Struct("device_foo", [
> ("bar", some
Wei Liu writes ("Re: [PATCH v11 1/2] libxl: add support for vscsi"):
> What Ian wanted was that we need clear correlation of xl configuration
> syntax with libxl API fields. For example, for a FOO device
Thanks for explaining, yes.
> However, I don't think that can be easily achieved in the case
On Fri, Apr 08, 2016 at 07:01:30AM +, Olaf Hering wrote:
> Port pvscsi support from xend to libxl:
>
> vscsi=['pdev,vdev{,options}']
> xl scsi-attach
> xl scsi-detach
> xl scsi-list
>
> Signed-off-by: Olaf Hering
> Cc: Ian Jackson
> Cc: Stefano Stabellini
> Cc: Ian Campbell
> Cc: Wei
On Fri, Apr 08, Olaf Hering wrote:
> +int xlu_vscsi_get_ctrl(XLU_Config *cfg, libxl_ctx *ctx, uint32_t domid,
> + const char *str,
> + libxl_device_vscsictrl *ctrl,
> + libxl_device_vscsidev *dev,
> + libxl_dev
On 08/04/16 09:01, Olaf Hering wrote:
> Port pvscsi support from xend to libxl:
>
> vscsi=['pdev,vdev{,options}']
> xl scsi-attach
> xl scsi-detach
> xl scsi-list
>
> Signed-off-by: Olaf Hering
> Cc: Ian Jackson
> Cc: Stefano Stabellini
> Cc: Ian Campbell
> Cc: Wei Liu
Reviewed-by: Juer
Port pvscsi support from xend to libxl:
vscsi=['pdev,vdev{,options}']
xl scsi-attach
xl scsi-detach
xl scsi-list
Signed-off-by: Olaf Hering
Cc: Ian Jackson
Cc: Stefano Stabellini
Cc: Ian Campbell
Cc: Wei Liu
---
docs/man/xl.cfg.pod.5| 56 ++
docs/man/xl.pod.1
12 matches
Mail list logo
