Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-09 Thread Daniel Kiper
On Fri, Dec 09, 2016 at 01:19:24AM -0700, Jan Beulich wrote: > >>> On 09.12.16 at 00:08, wrote: [...] > > I have checked it. It requires at least some changes made by patch #1 which > > has "Reviewed-by: Jan Beulich ". Of course I can change > > this but then I think that I should drop your Revi

Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-09 Thread Jan Beulich
>>> On 09.12.16 at 00:08, wrote: > On Wed, Dec 07, 2016 at 06:27:58PM +0100, Daniel Kiper wrote: >> On Wed, Dec 07, 2016 at 06:43:40AM -0700, Jan Beulich wrote: >> > >>> On 05.12.16 at 23:25, wrote: >> > > Current early command line parser implementation in assembler >> > > is very difficult to c

Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-08 Thread Daniel Kiper
On Wed, Dec 07, 2016 at 06:27:58PM +0100, Daniel Kiper wrote: > On Wed, Dec 07, 2016 at 06:43:40AM -0700, Jan Beulich wrote: > > >>> On 05.12.16 at 23:25, wrote: > > > Current early command line parser implementation in assembler > > > is very difficult to change to relocatable stuff using segment

Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-07 Thread Daniel Kiper
On Wed, Dec 07, 2016 at 06:43:40AM -0700, Jan Beulich wrote: > >>> On 05.12.16 at 23:25, wrote: > > Current early command line parser implementation in assembler > > is very difficult to change to relocatable stuff using segment > > registers. This requires a lot of changes in very weird and > > f

Re: [Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-07 Thread Jan Beulich
>>> On 05.12.16 at 23:25, wrote: > Current early command line parser implementation in assembler > is very difficult to change to relocatable stuff using segment > registers. This requires a lot of changes in very weird and > fragile code. So, reimplement this functionality in C. This > way code w

[Xen-devel] [PATCH v11 08/13] x86/boot: implement early command line parser in C

2016-12-05 Thread Daniel Kiper
Current early command line parser implementation in assembler is very difficult to change to relocatable stuff using segment registers. This requires a lot of changes in very weird and fragile code. So, reimplement this functionality in C. This way code will be relocatable out of the box (without p