On Wed, Dec 07, 2016 at 06:27:58PM +0100, Daniel Kiper wrote: > On Wed, Dec 07, 2016 at 06:43:40AM -0700, Jan Beulich wrote: > > >>> On 05.12.16 at 23:25, <daniel.ki...@oracle.com> wrote: > > > Current early command line parser implementation in assembler > > > is very difficult to change to relocatable stuff using segment > > > registers. This requires a lot of changes in very weird and > > > fragile code. So, reimplement this functionality in C. This > > > way code will be relocatable out of the box (without playing > > > with segment registers) and much easier to maintain. > > > > > > Additionally, put all common cmdline.c and reloc.c definitions > > > into defs.h header. This way we do not duplicate needlessly > > > some stuff. > > > > > > And finally remove unused xen/include/asm-x86/config.h > > > header from reloc.c dependencies. > > > > > > Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> > > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > > > Acked-by: Jan Beulich <jbeul...@suse.com> > > > > As you may have seen I've applied patches 2..4. I would also > > Great! Thanks a lot! > > > have applied this one, but it fails to apply cleanly. Whether > > that's because it needs re-basing or because it can't be applied > > out of order I can't tell. In order for you to not have to re-submit
I have checked it. It requires at least some changes made by patch #1 which has "Reviewed-by: Jan Beulich <jbeul...@suse.com>". Of course I can change this but then I think that I should drop your Reviewed-by from #1 and your Acked-by from #8. Does it pays? I think that we can do that in a bit different way. If there are no more comments please apply everything as is. If any new comment, worth taking into account, pop up I can rearrange patches order and drop your Reviewed-by/Acked-by too. Does it work for you? Daniel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
