Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-28 Thread Andrii Anisov
Julien, > There is no automatic test on all the possible configurations, although we > have > travis to test build (and not booting) a random Kconfig. I guess there is no need to test booting of a "random" Kconfig within the mainline anyway. The full-featured defconfig would be enough to be prov

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Andrew Cooper
On 23/11/16 19:28, Julien Grall wrote: > > > On 23/11/16 15:47, Andrii Anisov wrote: >> Hello Julien, > > Hi Andrii, > >>> The ACPI support is pretty much contained in a single file and I am >>> not sure you will win much space. >>> Can you explain why the ACPI guest support should be optional? >>

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Julien Grall
On 23/11/16 15:47, Andrii Anisov wrote: Hello Julien, Hi Andrii, The ACPI support is pretty much contained in a single file and I am not sure you will win much space. Can you explain why the ACPI guest support should be optional? This would increase the system configurability and would le

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Andrii Anisov
Hello Julien, > The ACPI support is pretty much contained in a single file and I am not sure > you will win much space. > Can you explain why the ACPI guest support should be optional? This would increase the system configurability and would let one shrink a system to a minimal footprint with req

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Julien Grall
Hello Andrii, On 23/11/16 14:12, Andrii Anisov wrote: But before you write any code, let me try to understand the real issue first: you're trying to cross-build ARM tools on x86, but x86 iasl doesn't support ARM ACPI definition(s), right? Well, as I stated here [1], I'm pretty far from ACPI and

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Wei Liu
On Wed, Nov 23, 2016 at 02:34:04PM +, Julien Grall wrote: > Hi Wei, > > On 23/11/16 14:29, Wei Liu wrote: > >On Wed, Nov 23, 2016 at 04:12:28PM +0200, Andrii Anisov wrote: > >>>But before you write any code, let me try to understand the real issue > >>>first: you're trying to cross-build ARM t

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Julien Grall
Hi Wei, On 23/11/16 14:29, Wei Liu wrote: On Wed, Nov 23, 2016 at 04:12:28PM +0200, Andrii Anisov wrote: But before you write any code, let me try to understand the real issue first: you're trying to cross-build ARM tools on x86, but x86 iasl doesn't support ARM ACPI definition(s), right? Well

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Wei Liu
On Wed, Nov 23, 2016 at 04:12:28PM +0200, Andrii Anisov wrote: > > But before you write any code, let me try to understand the real issue > > first: you're trying to cross-build ARM tools on x86, but x86 > > iasl doesn't support ARM ACPI definition(s), right? > Well, as I stated here [1], I'm prett

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Jan Beulich
>>> On 23.11.16 at 15:05, wrote: > But before you write any code, let me try to understand the real issue > first: you're trying to cross-build ARM tools on x86, but x86 > iasl doesn't support ARM ACPI definition(s), right? No, the problem is that Shannon has broken cross builds of libacpi's mk_d

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Andrii Anisov
> But before you write any code, let me try to understand the real issue > first: you're trying to cross-build ARM tools on x86, but x86 > iasl doesn't support ARM ACPI definition(s), right? Well, as I stated here [1], I'm pretty far from ACPI and understanding of what's going wrong with the compil

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Wei Liu
On Wed, Nov 23, 2016 at 03:59:54PM +0200, Andrii Anisov wrote: > > It is defined in config/arm64.mk, which is included by various > > makefiles. > As I got, it is included by Config.mk which consequently included by > different makefiles in hypervisor, tools, docs, stubdom. > It looks like a piece

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Andrii Anisov
> It is defined in config/arm64.mk, which is included by various > makefiles. As I got, it is included by Config.mk which consequently included by different makefiles in hypervisor, tools, docs, stubdom. It looks like a piece of legasy configuration code, I see moves of CONFIG_ options from it to K

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Wei Liu
On Wed, Nov 23, 2016 at 03:03:54PM +0200, Andrii Anisov wrote: > > This will not work because Kconfig support only exists for the hypervisor. > > So I totally confused where CONFIG_ARM_64 is defined for tools. > It is defined in config/arm64.mk, which is included by various makefiles. > Sincer

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Andrii Anisov
> This will not work because Kconfig support only exists for the hypervisor. So I totally confused where CONFIG_ARM_64 is defined for tools. Sincerely, Andrii Anisov. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Julien Grall
Hello, On 23/11/16 12:25, Andrii Anisov wrote: Make the libxl ACPI support build configurable by the same config option as the hypervisor side support. This will not work because Kconfig support only exists for the hypervisor. Furthermore, people may want to disable ACPI for the host but stil

[Xen-devel] [PATCH v1] libxl: Make an ACPI support build for ARM64 configurable.

2016-11-23 Thread Andrii Anisov
Make the libxl ACPI support build configurable by the same config option as the hypervisor side support. Signed-off-by: Andrii Anisov --- tools/libxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index f5053a0..a4e9319 10