Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-28 Thread Kai Huang
On 09/24/2015 05:10 PM, Tim Deegan wrote: At 01:02 -0600 on 24 Sep (1443056566), Jan Beulich wrote: On 23.09.15 at 17:46, wrote: At 16:18 +0100 on 23 Sep (1443025126), Wei Liu wrote: With the discussion still not finalised I'm a bit worried that this issue will block the release. I think w

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Wei Liu
On Thu, Sep 24, 2015 at 03:33:18AM -0600, Jan Beulich wrote: > >>> On 24.09.15 at 11:10, wrote: > > At 01:02 -0600 on 24 Sep (1443056566), Jan Beulich wrote: > >> --- a/xen/arch/x86/mm/p2m-ept.c > >> +++ b/xen/arch/x86/mm/p2m-ept.c > >> @@ -130,14 +130,18 @@ static void ept_p2m_type_to_flags(struc

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Wei Liu
On Thu, Sep 24, 2015 at 11:45:00AM +0100, Wei Liu wrote: > On Thu, Sep 24, 2015 at 03:33:18AM -0600, Jan Beulich wrote: > > >>> On 24.09.15 at 11:10, wrote: > > > At 01:02 -0600 on 24 Sep (1443056566), Jan Beulich wrote: > > >> --- a/xen/arch/x86/mm/p2m-ept.c > > >> +++ b/xen/arch/x86/mm/p2m-ept.c

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Jan Beulich
>>> On 24.09.15 at 11:13, wrote: >>> etc along with adjusting the existing gating of PML on AD being >>> available (perhaps by simply stripping the respective bit from what >>> we read from MSR_IA32_VMX_EPT_VPID_CAP). Of course this >>> then ignores the fact that the erratum only affects the A bi

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Jan Beulich
>>> On 24.09.15 at 11:10, wrote: > At 01:02 -0600 on 24 Sep (1443056566), Jan Beulich wrote: >> --- a/xen/arch/x86/mm/p2m-ept.c >> +++ b/xen/arch/x86/mm/p2m-ept.c >> @@ -130,14 +130,18 @@ static void ept_p2m_type_to_flags(struct p2m_domain >> *p2m, ept_entry_t *entry, >> break; >>

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Tim Deegan
At 10:13 +0100 on 24 Sep (1443089607), Andrew Cooper wrote: > > >> etc along with adjusting the existing gating of PML on AD being > >> available (perhaps by simply stripping the respective bit from what > >> we read from MSR_IA32_VMX_EPT_VPID_CAP). Of course this > >> then ignores the fact that t

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Andrew Cooper
etc along with adjusting the existing gating of PML on AD being available (perhaps by simply stripping the respective bit from what we read from MSR_IA32_VMX_EPT_VPID_CAP). Of course this then ignores the fact that the erratum only affects the A bit, but I think we can live with that. I also th

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Tim Deegan
At 01:02 -0600 on 24 Sep (1443056566), Jan Beulich wrote: > >>> On 23.09.15 at 17:46, wrote: > > At 16:18 +0100 on 23 Sep (1443025126), Wei Liu wrote: > >> With the discussion still not finalised I'm a bit worried that this > >> issue will block the release. > >> > >> I think we have a few option

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-24 Thread Jan Beulich
>>> On 23.09.15 at 17:46, wrote: > At 16:18 +0100 on 23 Sep (1443025126), Wei Liu wrote: >> With the discussion still not finalised I'm a bit worried that this >> issue will block the release. >> >> I think we have a few options here. I will list them in order of my >> preference. Please correct

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-23 Thread Tim Deegan
At 16:18 +0100 on 23 Sep (1443025126), Wei Liu wrote: > With the discussion still not finalised I'm a bit worried that this > issue will block the release. > > I think we have a few options here. I will list them in order of my > preference. Please correct me if I'm talking non-sense, and feel fre

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-23 Thread George Dunlap
On 09/23/2015 04:18 PM, Wei Liu wrote: > With the discussion still not finalised I'm a bit worried that this > issue will block the release. > > I think we have a few options here. I will list them in order of my > preference. Please correct me if I'm talking non-sense, and feel free to > add more

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-23 Thread Konrad Rzeszutek Wilk
On Wed, Sep 23, 2015 at 04:18:46PM +0100, Wei Liu wrote: > With the discussion still not finalised I'm a bit worried that this > issue will block the release. > > I think we have a few options here. I will list them in order of my > preference. Please correct me if I'm talking non-sense, and feel

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-23 Thread Wei Liu
With the discussion still not finalised I'm a bit worried that this issue will block the release. I think we have a few options here. I will list them in order of my preference. Please correct me if I'm talking non-sense, and feel free to add more options if I miss anything. 1. Disable PML on bro

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-21 Thread Tim Deegan
At 20:47 +0100 on 16 Sep (1442436442), Andrew Cooper wrote: > On 16/09/2015 09:47, Ross Lagerwall wrote: > > Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for > > log-dirty"), the A and D bits of EPT paging entries are set > > unconditionally, regardless of whether PML is enabled or no

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-21 Thread Jan Beulich
>>> On 16.09.15 at 21:47, wrote: > On 16/09/2015 09:47, Ross Lagerwall wrote: >> Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for >> log-dirty"), the A and D bits of EPT paging entries are set >> unconditionally, regardless of whether PML is enabled or not. This >> causes a regressio

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-16 Thread Andrew Cooper
On 16/09/2015 09:47, Ross Lagerwall wrote: > Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for > log-dirty"), the A and D bits of EPT paging entries are set > unconditionally, regardless of whether PML is enabled or not. This > causes a regression in Xen 4.6 on some processors due to I

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-16 Thread Wei Liu
On Wed, Sep 16, 2015 at 04:17:29PM +0100, Ross Lagerwall wrote: > On 09/16/2015 03:46 PM, Wei Liu wrote: > >On Wed, Sep 16, 2015 at 09:47:51AM +0100, Ross Lagerwall wrote: > >>Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for > >>log-dirty"), the A and D bits of EPT paging entries are

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-16 Thread Ross Lagerwall
On 09/16/2015 03:46 PM, Wei Liu wrote: On Wed, Sep 16, 2015 at 09:47:51AM +0100, Ross Lagerwall wrote: Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for log-dirty"), the A and D bits of EPT paging entries are set unconditionally, regardless of whether PML is enabled or not. This cau

Re: [Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-16 Thread Wei Liu
On Wed, Sep 16, 2015 at 09:47:51AM +0100, Ross Lagerwall wrote: > Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for > log-dirty"), the A and D bits of EPT paging entries are set > unconditionally, regardless of whether PML is enabled or not. This > causes a regression in Xen 4.6 on som

[Xen-devel] [PATCH for-4.6] p2m/ept: Set the A bit only if PML is enabled

2015-09-16 Thread Ross Lagerwall
Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for log-dirty"), the A and D bits of EPT paging entries are set unconditionally, regardless of whether PML is enabled or not. This causes a regression in Xen 4.6 on some processors due to Intel Errata AVR41 -- HVM guests get severe memory c