Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-08 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API"): > There's a difference between "making it intelligent" and "not making it > broken". :-) Given that users can potentially cause a number of these > things to fail just by pr

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-08 Thread George Dunlap
On 04/02/16 14:39, Juergen Gross wrote: > On 04/02/16 02:53, Chun Yan Liu wrote: >> >> >>>>> On 2/3/2016 at 10:33 PM, in message <56b20fcc.3010...@citrix.com>, George >> Dunlap wrote: >>> On 02/02/16 18:11, Ian Jackson wrote: >>>&g

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-04 Thread Juergen Gross
On 04/02/16 02:53, Chun Yan Liu wrote: > > >>>> On 2/3/2016 at 10:33 PM, in message <56b20fcc.3010...@citrix.com>, George > Dunlap wrote: >> On 02/02/16 18:11, Ian Jackson wrote: >>> George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
>>> On 2/3/2016 at 10:33 PM, in message <56b20fcc.3010...@citrix.com>, George Dunlap wrote: > On 02/02/16 18:11, Ian Jackson wrote: > > George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb > API"): > >> There are effect

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
ce.com>, Ian Jackson > > wrote: > >> George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb > API"): > >>> There are effectively four states a device can be in, from the > >>> 'assignment' point of view:

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread George Dunlap
On 03/02/16 07:34, Chun Yan Liu wrote: > > >>>> On 2/3/2016 at 02:11 AM, in message > <22192.61775.427189.268...@mariner.uk.xensource.com>, Ian Jackson > wrote: >> George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb >> API&quo

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread George Dunlap
On 02/02/16 18:11, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API"): >> There are effectively four states a device can be in, from the >> 'assignment' point of view: >> >> 1. Assigned to the normal Li

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-03 Thread Chun Yan Liu
>>> On 2/3/2016 at 12:48 AM, in message , George Dunlap wrote: > On Tue, Jan 19, 2016 at 3:48 PM, Ian Jackson > wrote: > > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): > >> > Ought this function to really report success if these calls fail ? > >> > >> I think so. Till here

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-02 Thread Chun Yan Liu
>>> On 2/3/2016 at 02:11 AM, in message <22192.61775.427189.268...@mariner.uk.xensource.com>, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb > API"): > > There are effectively four states a device can be in

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-02 Thread Ian Jackson
George Dunlap writes ("Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API"): > There are effectively four states a device can be in, from the > 'assignment' point of view: > > 1. Assigned to the normal Linux device driver(s) for the USB device > > 2. Ass

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-02 Thread George Dunlap
On Tue, Jan 19, 2016 at 3:48 PM, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): >> > Ought this function to really report success if these calls fail ? >> >> I think so. Till here, the USB device has already been unbound from >> usbback and removed from xenstore.

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-02 Thread George Dunlap
On Tue, Jan 19, 2016 at 3:48 PM, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): >> +static int usbback_dev_unassign(libxl__gc *gc, const char *busid) >> +{ > ... >> +/* Till here, USB device has been unbound from USBBACK and >> + * removed from xenstore,

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-02-01 Thread Chun Yan Liu
>>> On 1/27/2016 at 12:21 AM, in message , George Dunlap wrote: > On Tue, Jan 26, 2016 at 7:43 AM, Chun Yan Liu wrote: > > > > > On 1/20/2016 at 12:56 PM, in message > > <569f83f502660009e...@relay2.provo.novell.com>, "Chun Yan Liu" > > wrote: > > > >> > > On 1/19/2016 at

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-26 Thread Chun Yan Liu
>>> On 1/27/2016 at 12:12 AM, in message <20160126161253.ga9...@gmail.com>, Olaf Hering wrote: > On Tue, Jan 19, Chunyan Liu wrote: > > > +++ b/tools/libxl/libxl.c > > @@ -3204,7 +3204,7 @@ void > libxl__device_disk_local_initiate_detach(libxl__egc *egc, > > aodev->dev = device;

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-26 Thread George Dunlap
On Tue, Jan 26, 2016 at 7:43 AM, Chun Yan Liu wrote: > > On 1/20/2016 at 12:56 PM, in message > <569f83f502660009e...@relay2.provo.novell.com>, "Chun Yan Liu" > wrote: > >> > On 1/19/2016 at 11:48 PM, in message >> <22174.23240.402164.635...@mariner.uk.xensource.com>, Ian Jackson >>

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-26 Thread Olaf Hering
On Tue, Jan 19, Chunyan Liu wrote: > +++ b/tools/libxl/libxl.c > @@ -3204,7 +3204,7 @@ void > libxl__device_disk_local_initiate_detach(libxl__egc *egc, > aodev->dev = device; > aodev->callback = local_device_detach_cb; > aodev->force = 0; > -libxl__initiate_devi

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-25 Thread Chun Yan Liu
>>> On 1/20/2016 at 12:56 PM, in message <569f83f502660009e...@relay2.provo.novell.com>, "Chun Yan Liu" wrote: > On 1/19/2016 at 11:48 PM, in message > <22174.23240.402164.635...@mariner.uk.xensource.com>, Ian Jackson > wrote: > > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-19 Thread Chun Yan Liu
>>> On 1/19/2016 at 11:48 PM, in message <22174.23240.402164.635...@mariner.uk.xensource.com>, Ian Jackson wrote: > Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): > > Add pvusb APIs, including: > > - attach/detach (create/destroy) virtual usb controller. > > - attach/detach u

Re: [Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-19 Thread Ian Jackson
Chunyan Liu writes ("[PATCH V13 3/5] libxl: add pvusb API"): > Add pvusb APIs, including: > - attach/detach (create/destroy) virtual usb controller. > - attach/detach usb device > - list usb controller and usb devices > - some other helper functions Thanks. This is making progress but I'm af

[Xen-devel] [PATCH V13 3/5] libxl: add pvusb API

2016-01-19 Thread Chunyan Liu
Add pvusb APIs, including: - attach/detach (create/destroy) virtual usb controller. - attach/detach usb device - list usb controller and usb devices - some other helper functions Signed-off-by: Chunyan Liu Signed-off-by: Simon Cao Signed-off-by: George Dunlap --- changes: * address error ha