Re: [Xen-devel] [PATCH RFC 5/9] libxl: introduce specific JSON error codes

2015-06-24 Thread Ian Jackson
Rob Hoes writes ("[PATCH RFC 5/9] libxl: introduce specific JSON error codes"): > Signed-off-by: Rob Hoes ... > -rc = ERROR_FAIL; > +rc = ERROR_JSON_SET_CONFIG; I think I'd rather have ERROR_USERDATA_ACCESS (see my previous comments about LOCK_FAIL) or maybe ERROR_USERDATA_READ / ERROR_US

[Xen-devel] [PATCH RFC 5/9] libxl: introduce specific JSON error codes

2015-06-24 Thread Rob Hoes
Signed-off-by: Rob Hoes --- tools/libxl/libxl_dom.c | 6 +++--- tools/libxl/libxl_internal.c | 4 +--- tools/libxl/libxl_json.c | 4 ++-- tools/libxl/libxl_types.idl | 5 + 4 files changed, 11 insertions(+), 8 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_do