Re: [Xen-devel] [PATCH RFC 27/35] arm: acpi map mmio regions to dom0

2015-02-11 Thread Julien Grall
Hi Parth, On 04/02/2015 22:02, parth.di...@linaro.org wrote: From: Parth Dixit map mmio regions described in uefi tables to dom0 address space Signed-off-by: Parth Dixit --- xen/arch/arm/domain_build.c | 54 + 1 file changed, 54 insertions(+) d

Re: [Xen-devel] [PATCH RFC 27/35] arm: acpi map mmio regions to dom0

2015-02-06 Thread Stefano Stabellini
On Fri, 6 Feb 2015, Julien Grall wrote: > On 06/02/2015 03:40, Parth Dixit wrote: > > > > +static int map_acpi_regions(struct domain *d) > > > > +{ > > > > +int res; > > > > + > > > > +res = acpi_map_mmio(d); > > > > +if ( res ) > > > > +return res; > > > > + > > > > +return

Re: [Xen-devel] [PATCH RFC 27/35] arm: acpi map mmio regions to dom0

2015-02-05 Thread Julien Grall
On 06/02/2015 03:40, Parth Dixit wrote: +static int map_acpi_regions(struct domain *d) +{ +int res; + +res = acpi_map_mmio(d); +if ( res ) +return res; + +return 0; +} I don't think that splitting the code in two functions is useful. Just implement the remapping here. o

Re: [Xen-devel] [PATCH RFC 27/35] arm: acpi map mmio regions to dom0

2015-02-05 Thread Parth Dixit
On 5 February 2015 at 22:19, Stefano Stabellini wrote: > On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: >> From: Parth Dixit >> >> map mmio regions described in uefi tables to dom0 address space >> >> Signed-off-by: Parth Dixit >> --- >> xen/arch/arm/domain_build.c | 54 >> +

Re: [Xen-devel] [PATCH RFC 27/35] arm: acpi map mmio regions to dom0

2015-02-05 Thread Stefano Stabellini
On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: > From: Parth Dixit > > map mmio regions described in uefi tables to dom0 address space > > Signed-off-by: Parth Dixit > --- > xen/arch/arm/domain_build.c | 54 > + > 1 file changed, 54 insertions(+)

[Xen-devel] [PATCH RFC 27/35] arm: acpi map mmio regions to dom0

2015-02-04 Thread parth . dixit
From: Parth Dixit map mmio regions described in uefi tables to dom0 address space Signed-off-by: Parth Dixit --- xen/arch/arm/domain_build.c | 54 + 1 file changed, 54 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_buil