Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-10 Thread Julien Grall
Hi Ian, On 05/02/2015 22:52, Ian Campbell wrote: On Thu, 2015-02-05 at 22:29 +0800, Julien Grall wrote: On 05/02/2015 19:42, Ian Campbell wrote: On Wed, 2015-02-04 at 21:57 +, Julien Grall wrote: I believe that most of the SPCR parsing should be generic, so maybe you could extend the DEV

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-05 Thread Ian Campbell
On Thu, 2015-02-05 at 15:27 +, Stefano Stabellini wrote: > On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: > > From: Naresh Bhat > > > > Parse ACPI SPCR (Serial Port Console Redirection table) table and > > initialize the serial port pl011. > > > > Signed-off-by: Naresh Bhat > > Signed-of

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-05 Thread Stefano Stabellini
On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: > From: Naresh Bhat > > Parse ACPI SPCR (Serial Port Console Redirection table) table and > initialize the serial port pl011. > > Signed-off-by: Naresh Bhat > Signed-off-by: Parth Dixit > --- > xen/arch/arm/setup.c | 6 + > xen/drive

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-05 Thread Ian Campbell
On Thu, 2015-02-05 at 22:29 +0800, Julien Grall wrote: > Hi Ian, > > On 05/02/2015 19:42, Ian Campbell wrote: > > On Wed, 2015-02-04 at 21:57 +, Julien Grall wrote: > > > >> I believe that most of the SPCR parsing should be generic, so maybe you > >> could extend the DEVICE interface to handle

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-05 Thread Julien Grall
Hi Ian, On 05/02/2015 19:42, Ian Campbell wrote: On Wed, 2015-02-04 at 21:57 +, Julien Grall wrote: I believe that most of the SPCR parsing should be generic, so maybe you could extend the DEVICE interface to handle the ACPI case. Extending DT_DEVICE would be confusing IMHO. The answer i

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-05 Thread Ian Campbell
On Wed, 2015-02-04 at 21:57 +, Julien Grall wrote: > I believe that most of the SPCR parsing should be generic, so maybe you > could extend the DEVICE interface to handle the ACPI case. Extending DT_DEVICE would be confusing IMHO. The answer is probably a similar but parallel ACPI_DEVICE mec

Re: [Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-04 Thread Julien Grall
Hi Parth, On 04/02/2015 14:02, parth.di...@linaro.org wrote: From: Naresh Bhat Parse ACPI SPCR (Serial Port Console Redirection table) table and initialize the serial port pl011. Signed-off-by: Naresh Bhat Signed-off-by: Parth Dixit --- xen/arch/arm/setup.c | 6 + xen/drivers/c

[Xen-devel] [PATCH RFC 17/35] pl011: Initialize serial from ACPI SPCR table

2015-02-04 Thread parth . dixit
From: Naresh Bhat Parse ACPI SPCR (Serial Port Console Redirection table) table and initialize the serial port pl011. Signed-off-by: Naresh Bhat Signed-off-by: Parth Dixit --- xen/arch/arm/setup.c | 6 + xen/drivers/char/pl011.c | 69 +++