Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-17 Thread Julien Grall
On 17/06/16 10:15, Stefano Stabellini wrote: On Fri, 17 Jun 2016, Julien Grall wrote: Hello Shannon, On 17/06/16 04:29, Shannon Zhao wrote: On 2016/6/6 19:40, Stefano Stabellini wrote: ACPI tables for ARM guests should be user configurable: acpi=1 in the VM config file enables them, with de

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-17 Thread Stefano Stabellini
On Fri, 17 Jun 2016, Julien Grall wrote: > Hello Shannon, > > On 17/06/16 04:29, Shannon Zhao wrote: > > On 2016/6/6 19:40, Stefano Stabellini wrote: > > > ACPI tables for ARM guests should be user configurable: acpi=1 in the VM > > > config file enables them, with default off. > > While the confi

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-17 Thread Julien Grall
Hello Shannon, On 17/06/16 04:29, Shannon Zhao wrote: On 2016/6/6 19:40, Stefano Stabellini wrote: ACPI tables for ARM guests should be user configurable: acpi=1 in the VM config file enables them, with default off. While the configuration "acpi" already exists for HVM guest configuration, do

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-16 Thread Shannon Zhao
On 2016/6/6 19:40, Stefano Stabellini wrote: > ACPI tables for ARM guests should be user configurable: acpi=1 in the VM > config file enables them, with default off. While the configuration "acpi" already exists for HVM guest configuration, do we plan to reuse it or use a new name, e.g. arm_acpi?

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Wei Liu
On Tue, Jun 07, 2016 at 10:48:36AM +0100, Stefano Stabellini wrote: > On Mon, 6 Jun 2016, Julien Grall wrote: > > Hello, > > > > On 06/06/16 13:04, Stefano Stabellini wrote: > > > On Mon, 6 Jun 2016, Julien Grall wrote: > > > > On 06/06/16 12:40, Stefano Stabellini wrote: > > > > > On Tue, 31 May

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Julien Grall
On 07/06/16 12:39, Shannon Zhao wrote: On 2016/6/7 19:36, Julien Grall wrote: On 07/06/16 12:30, Shannon Zhao wrote: On 2016/6/7 19:19, Julien Grall wrote: On 31/05/16 06:02, Shannon Zhao wrote: +static void make_acpi_gtdt(libxl__gc *gc, struct xc_dom_image *dom) +{ +struct acpi_gtd

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Shannon Zhao
On 2016/6/7 19:36, Julien Grall wrote: > > > On 07/06/16 12:30, Shannon Zhao wrote: >> On 2016/6/7 19:19, Julien Grall wrote: >>> On 31/05/16 06:02, Shannon Zhao wrote: +static void make_acpi_gtdt(libxl__gc *gc, struct xc_dom_image *dom) +{ +struct acpi_gtdt_descriptor *gtdt;

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Julien Grall
On 07/06/16 12:30, Shannon Zhao wrote: On 2016/6/7 19:19, Julien Grall wrote: On 31/05/16 06:02, Shannon Zhao wrote: +static void make_acpi_gtdt(libxl__gc *gc, struct xc_dom_image *dom) +{ +struct acpi_gtdt_descriptor *gtdt; + +gtdt = libxl__zalloc(gc, sizeof(*gtdt)); + +gtdt->sec

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Shannon Zhao
On 2016/6/7 19:19, Julien Grall wrote: > Hello Shannon, > > On 31/05/16 06:02, Shannon Zhao wrote: >> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c >> index 9e99159..0fb4f69 100644 >> --- a/tools/libxl/libxl_arm.c >> +++ b/tools/libxl/libxl_arm.c >> @@ -3,6 +3,7 @@ >> #include

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Julien Grall
Hello Shannon, On 31/05/16 06:02, Shannon Zhao wrote: diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 9e99159..0fb4f69 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -3,6 +3,7 @@ #include "libxl_libfdt_compat.h" #include +#include #include

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Julien Grall
Hello, On 06/06/16 13:18, Wei Liu wrote: On Tue, May 31, 2016 at 01:02:57PM +0800, Shannon Zhao wrote: +static int prepare_acpi(libxl__gc *gc, libxl_domain_build_info *info, +libxl__domain_build_state *state, +struct xc_dom_image *dom) libxl__pr

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Stefano Stabellini
On Mon, 6 Jun 2016, Julien Grall wrote: > Hello, > > On 06/06/16 13:04, Stefano Stabellini wrote: > > On Mon, 6 Jun 2016, Julien Grall wrote: > > > On 06/06/16 12:40, Stefano Stabellini wrote: > > > > On Tue, 31 May 2016, Shannon Zhao wrote: > > > > > From: Shannon Zhao > > > > > > > > ACPI tabl

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-07 Thread Stefano Stabellini
On Mon, 6 Jun 2016, Julien Grall wrote: > Hi Stefano, > > On 06/06/16 15:50, Stefano Stabellini wrote: > > On Mon, 6 Jun 2016, Shannon Zhao wrote: > > > I don't know why we need to disable ACPI because we can provide ACPI > > > tables but guest could choose to not use it. And for ARM32 domain, sin

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Julien Grall
Hi Stefano, On 06/06/16 15:50, Stefano Stabellini wrote: On Mon, 6 Jun 2016, Shannon Zhao wrote: I don't know why we need to disable ACPI because we can provide ACPI tables but guest could choose to not use it. And for ARM32 domain, since the linux guest kernel doesn't support ACPI, even we pro

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Julien Grall
Hello, On 06/06/16 13:04, Stefano Stabellini wrote: On Mon, 6 Jun 2016, Julien Grall wrote: On 06/06/16 12:40, Stefano Stabellini wrote: On Tue, 31 May 2016, Shannon Zhao wrote: From: Shannon Zhao ACPI tables for ARM guests should be user configurable: acpi=1 in the VM config file enables

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Stefano Stabellini
On Mon, 6 Jun 2016, Shannon Zhao wrote: > On 2016年06月06日 20:04, Stefano Stabellini wrote: > > On Mon, 6 Jun 2016, Julien Grall wrote: > >> > Hello, > >> > > >> > On 06/06/16 12:40, Stefano Stabellini wrote: > >>> > > On Tue, 31 May 2016, Shannon Zhao wrote: > > > > From: Shannon Zhao >

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Shannon Zhao
On 2016年06月06日 20:04, Stefano Stabellini wrote: > On Mon, 6 Jun 2016, Julien Grall wrote: >> > Hello, >> > >> > On 06/06/16 12:40, Stefano Stabellini wrote: >>> > > On Tue, 31 May 2016, Shannon Zhao wrote: > > > From: Shannon Zhao > > > > > > Construct GTDT table with the interrup

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Wei Liu
On Tue, May 31, 2016 at 01:02:57PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Construct GTDT table with the interrupt information of timers. > > Signed-off-by: Shannon Zhao > --- > tools/libxl/libxl_arm.c | 75 > - > 1 file changed, 74

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Stefano Stabellini
On Mon, 6 Jun 2016, Julien Grall wrote: > Hello, > > On 06/06/16 12:40, Stefano Stabellini wrote: > > On Tue, 31 May 2016, Shannon Zhao wrote: > > > From: Shannon Zhao > > > > > > Construct GTDT table with the interrupt information of timers. > > > > > > Signed-off-by: Shannon Zhao > > > --- >

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Julien Grall
Hello, On 06/06/16 12:40, Stefano Stabellini wrote: On Tue, 31 May 2016, Shannon Zhao wrote: From: Shannon Zhao Construct GTDT table with the interrupt information of timers. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 75 - 1

Re: [Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-06-06 Thread Stefano Stabellini
On Tue, 31 May 2016, Shannon Zhao wrote: > From: Shannon Zhao > > Construct GTDT table with the interrupt information of timers. > > Signed-off-by: Shannon Zhao > --- > tools/libxl/libxl_arm.c | 75 > - > 1 file changed, 74 insertions(+), 1 dele

[Xen-devel] [PATCH RESEND 05/14] libxl/arm: Construct ACPI GTDT table

2016-05-30 Thread Shannon Zhao
From: Shannon Zhao Construct GTDT table with the interrupt information of timers. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 75 - 1 file changed, 74 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/