Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 01:55:01PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM > test jobs"): > > Duplicate Debian PV and HVM test jobs for XSM testing. > ... > > do_hvm_debian_tests() { > > + test_xsm=$(xenbranch_xsm_variants) > > Thi

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Ian Jackson
Wei Liu writes ("[PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs"): > Duplicate Debian PV and HVM test jobs for XSM testing. ... > do_hvm_debian_tests() { > + test_xsm=$(xenbranch_xsm_variants) This variable needs to have a different name, with a plural init. "xsm_variants"

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs"): > On Tue, 2015-02-03 at 12:06 +, Wei Liu wrote: > > + if [ "x$xsm" = "xtrue" -a "x$platform" != "x" ]; then > > IIRC Ian previously indicated that he prefers to avoid " when it is > unnecess

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 12:12 +, Wei Liu wrote: > So > >if [ x$xsm = xtrue -a x$platform != x ] ; then AIUI, yes. (because you know $xsm and $platform cannot possibly contain spaces) ___ Xen-devel mailing list Xen-devel@lists.xen.org http://li

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 12:08:03PM +, Ian Campbell wrote: > On Tue, 2015-02-03 at 12:06 +, Wei Liu wrote: > > On Tue, Feb 03, 2015 at 11:22:44AM +, Ian Campbell wrote: > > > On Tue, 2015-02-03 at 10:36 +, Wei Liu wrote: > > > > Duplicate Debian PV and HVM test jobs for XSM testing.

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 12:06 +, Wei Liu wrote: > On Tue, Feb 03, 2015 at 11:22:44AM +, Ian Campbell wrote: > > On Tue, 2015-02-03 at 10:36 +, Wei Liu wrote: > > > Duplicate Debian PV and HVM test jobs for XSM testing. > > > > If ~/.xen-osstest/config contains e.g. "PlatformsArmhf midway

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Wei Liu
On Tue, Feb 03, 2015 at 11:22:44AM +, Ian Campbell wrote: > On Tue, 2015-02-03 at 10:36 +, Wei Liu wrote: > > Duplicate Debian PV and HVM test jobs for XSM testing. > > If ~/.xen-osstest/config contains e.g. "PlatformsArmhf midway cubietruck > arndale" (correspodning to the platform-{...}

Re: [Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 10:36 +, Wei Liu wrote: > Duplicate Debian PV and HVM test jobs for XSM testing. If ~/.xen-osstest/config contains e.g. "PlatformsArmhf midway cubietruck arndale" (correspodning to the platform-{...} flag being set on some host) then I think this will generate a per platf

[Xen-devel] [PATCH OSSTEST v5 9/9] mfi-common, make-flight: create XSM test jobs

2015-02-03 Thread Wei Liu
Duplicate Debian PV and HVM test jobs for XSM testing. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson --- make-flight | 46 +++--- mfi-common | 12 ++-- 2 files changed, 41 insertions(+), 17 deletions(-) diff --git a/make-flight b/make