On Thu, 2015-01-22 at 15:19 +, Ian Campbell wrote:
> On Thu, 2015-01-22 at 15:17 +, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor
> > migration support."):
> > > On Tue, 2015-01-20 at 18:38 +, Ian Jackson wrote:
> > > > Again, I think you
Ian Campbell writes ("Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor
migration support."):
> On Thu, 2015-01-22 at 15:17 +, Ian Jackson wrote:
> > Magic in a different way would be:
> >
> > ->migrate($ts, $gho, { %$dho, Name => 'localhost' }, $timeout)
>
> In the caller? There is no $dho
On Thu, 2015-01-22 at 15:17 +, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor
> migration support."):
> > On Tue, 2015-01-20 at 18:38 +, Ian Jackson wrote:
> > > Again, I think you should pass the $dho rather than the name. In
> > > general it'
Ian Campbell writes ("Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor
migration support."):
> On Tue, 2015-01-20 at 18:38 +, Ian Jackson wrote:
> > Again, I think you should pass the $dho rather than the name. In
> > general it's better to pass the hash object to these kind of methods.
>
>
On Tue, 2015-01-20 at 18:38 +, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 12/18] Toolstack: Refactor migration
> support."):
> > Note that since the previous patch arranges for
> > ts-migration-support-check to continue to fail for libvirt the libvirt
> > code is not actually
Ian Campbell writes ("[PATCH OSSTEST v2 12/18] Toolstack: Refactor migration
support."):
> Note that since the previous patch arranges for
> ts-migration-support-check to continue to fail for libvirt the libvirt
> code is not actually called yet (and will die if it is). This patch is
> mainly incl
Note that since the previous patch arranges for
ts-migration-support-check to continue to fail for libvirt the libvirt
code is not actually called yet (and will die if it is). This patch is
mainly included to reduce the number of users of
toolstack()->{Command} closer to zero.
Signed-off-by: Ian C
