Ian Campbell writes ("Re: [PATCH OSSTEST v2 12/18] Toolstack: Refactor migration support."): > On Tue, 2015-01-20 at 18:38 +0000, Ian Jackson wrote: > > Again, I think you should pass the $dho rather than the name. In > > general it's better to pass the hash object to these kind of methods. > > For ts-guest-localmigrate is there a cunning stunt you would recommend > to generate a $dho with ->{Name} == "localhost"? > > Or perhaps: > $dho ? $dho->{Name} : "localhost" > ? (i.e. $dho==undef => localhost)
That would do, although it's a big magic. Magic in a different way would be: ->migrate($ts, $gho, { %$dho, Name => 'localhost' }, $timeout) Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel