Re: [Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

2015-01-21 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle."): > > Perhaps the toolstack create method should take the $gho rather than > > the config file pathname, like the destroy method does ? > > Yes. In fact towards the end of the series I end up arranging that >

Re: [Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

2015-01-21 Thread Ian Campbell
On Tue, 2015-01-20 at 18:32 +, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v2 08/18] Toolstack: Refactor guest > lifecycle."): > > Implement destory/create as per toolstack methods, including implementing > > the > > libvirt version which previously didn't work. To do this we us

Re: [Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

2015-01-20 Thread Ian Jackson
Ian Campbell writes ("[PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle."): > Implement destory/create as per toolstack methods, including implementing the > libvirt version which previously didn't work. To do this we use the virsh > capability to convert an xl/xm style config file into

Re: [Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

2015-01-14 Thread Ian Jackson
Ian Campbell writes ("Re: [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle."): > On Tue, 2014-12-02 at 16:04 +, Ian Campbell wrote: > > +sub create ($$) { > > +my ($self,$cfg) = @_; > > +my $ho = $self->{Host}; > > +my $lcfg = $cfg; > > +$lcfg =~ s,/,-,g; > > +$

Re: [Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

2015-01-13 Thread Ian Campbell
On Tue, 2014-12-02 at 16:04 +, Ian Campbell wrote: > +sub create ($$) { > +my ($self,$cfg) = @_; > +my $ho = $self->{Host}; > +my $lcfg = $cfg; > +$lcfg =~ s,/,-,g; > +$lcfg = "$ho->{Name}--$lcfg"; > +target_cmd_root($ho, "virsh domxml-from-native xen-xm $cfg > $cfg.xml"

[Xen-devel] [PATCH OSSTEST v2 08/18] Toolstack: Refactor guest lifecycle.

2014-12-02 Thread Ian Campbell
Implement destory/create as per toolstack methods, including implementing the libvirt version which previously didn't work. To do this we use the virsh capability to convert an xl/xm style config file into the correct XML. xend basically calls into the xl helper since they are compatible. xl/x, u