Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Wei Liu
On Tue, Jun 14, 2016 at 05:31:56PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 3/3] libxl: update vcpus bitmap in retrieved guest > config"): > > ... because the available vcpu bitmap can change during domain life time > > due to cpu hotplug and unplug. > > Is this cpu hotplug something t

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-14 Thread Ian Jackson
Wei Liu writes ("[PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config"): > ... because the available vcpu bitmap can change during domain life time > due to cpu hotplug and unplug. Is this cpu hotplug something that the guest can cause, or are we just talking about toolstack changes ?

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Dario Faggioli
On Tue, 2016-06-07 at 17:46 +0100, Wei Liu wrote: > > > I agree it would be good to set the exact bits though -- if you > > > can > > > tell > > > me which field to test.  > > > > > Perhaps at least mention something about all this either in a > > comment > > or in the changelog? > > > What would

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Wei Liu
On Tue, Jun 07, 2016 at 06:22:27PM +0200, Dario Faggioli wrote: > On Tue, 2016-06-07 at 17:03 +0100, Wei Liu wrote: > > On Tue, Jun 07, 2016 at 03:45:29PM +0100, Anthony PERARD wrote: > > >  > > > > --- a/tools/libxl/libxl.c > > > > +++ b/tools/libxl/libxl.c > > > > @@ -7222,6 +7222,57 @@ void libx

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Wei Liu
On Tue, Jun 07, 2016 at 05:36:05PM +0100, Anthony PERARD wrote: > On Tue, Jun 07, 2016 at 05:03:07PM +0100, Wei Liu wrote: > > On Tue, Jun 07, 2016 at 03:45:29PM +0100, Anthony PERARD wrote: > > > On Tue, Jun 07, 2016 at 12:24:02PM +0100, Wei Liu wrote: > > > > ... because the available vcpu bitmap

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Anthony PERARD
On Tue, Jun 07, 2016 at 05:03:07PM +0100, Wei Liu wrote: > On Tue, Jun 07, 2016 at 03:45:29PM +0100, Anthony PERARD wrote: > > On Tue, Jun 07, 2016 at 12:24:02PM +0100, Wei Liu wrote: > > > ... because the available vcpu bitmap can change during domain life time > > > due to cpu hotplug and unplug.

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Dario Faggioli
On Tue, 2016-06-07 at 17:03 +0100, Wei Liu wrote: > On Tue, Jun 07, 2016 at 03:45:29PM +0100, Anthony PERARD wrote: > >  > > > --- a/tools/libxl/libxl.c > > > +++ b/tools/libxl/libxl.c > > > @@ -7222,6 +7222,57 @@ void libxl_mac_copy(libxl_ctx *ctx, > > > libxl_mac *dst, libxl_mac *src) > > >  

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Wei Liu
On Tue, Jun 07, 2016 at 03:45:29PM +0100, Anthony PERARD wrote: > On Tue, Jun 07, 2016 at 12:24:02PM +0100, Wei Liu wrote: > > ... because the available vcpu bitmap can change during domain life time > > due to cpu hotplug and unplug. > > > > For QEMU upstream, we interrogate QEMU for the number o

Re: [Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Anthony PERARD
On Tue, Jun 07, 2016 at 12:24:02PM +0100, Wei Liu wrote: > ... because the available vcpu bitmap can change during domain life time > due to cpu hotplug and unplug. > > For QEMU upstream, we interrogate QEMU for the number of vcpus. For > others, we look directly into xenstore for information. >

[Xen-devel] [PATCH 3/3] libxl: update vcpus bitmap in retrieved guest config

2016-06-07 Thread Wei Liu
... because the available vcpu bitmap can change during domain life time due to cpu hotplug and unplug. For QEMU upstream, we interrogate QEMU for the number of vcpus. For others, we look directly into xenstore for information. Reported-by: Jan Beulich Signed-off-by: Wei Liu --- tools/libxl/li