On Tue, 2016-06-07 at 17:46 +0100, Wei Liu wrote: > > > I agree it would be good to set the exact bits though -- if you > > > can > > > tell > > > me which field to test. > > > > > Perhaps at least mention something about all this either in a > > comment > > or in the changelog? > > > What would you like to see in a comment? I guess this is now moot > because the exact bits will be set. > Well, if the code ends up looking like:
"the most correct thing would be to set the proper bits, but it's hard/cumbersome/unknown how to do so, and setting all up until count it enough for making things work" Then, exactly that. :-) If the code does the most correct thing already, as you seem to say, then nothing. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
