Re: [Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()

2015-07-07 Thread Ian Jackson
Jennifer Herbert writes ("Re: [Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()"): > On 03/07/15 16:27, Ian Jackson wrote: > > Jennifer Herbert writes ("[Xen-devel] [PATCH 2/7] libxc: Use const pointer > > in local_file_dump()"): > >

Re: [Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()

2015-07-07 Thread Jennifer Herbert
On 03/07/15 16:27, Ian Jackson wrote: Jennifer Herbert writes ("[Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()"): By adding the const keyword, it is clearer to people and static analysis tools that no changes to the data are to be made. Would it be wrong fo

Re: [Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()

2015-07-03 Thread Ian Jackson
Jennifer Herbert writes ("[Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()"): > By adding the const keyword, it is clearer to people and static analysis > tools that no changes to the data are to be made. Would it be wrong for a future patch to add a field to

[Xen-devel] [PATCH 2/7] libxc: Use const pointer in local_file_dump()

2015-07-01 Thread Jennifer Herbert
By adding the const keyword, it is clearer to people and static analysis tools that no changes to the data are to be made. Signed-off-by: Jennifer Herbert --- tools/libxc/xc_core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/xc_core.c b/tools/libxc/xc_core.