Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-27 Thread Jan Beulich
>>> "Tian, Kevin" 12/23/16 6:48 AM >>> >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Thursday, December 22, 2016 11:37 PM >> >>> On 22.12.16 at 16:14, wrote: >> > My argument is that, instead of excluding the hook, the behaviour of the >> > emulation path should be made to function sen

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Tian, Kevin
> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, December 22, 2016 11:37 PM > > >>> On 22.12.16 at 16:14, wrote: > > On 22/12/16 14:58, Jan Beulich wrote: > > On 22.12.16 at 15:31, wrote: > >> On 22.12.16 at 14:47, wrote: > On 22/12/16 08:37, Jan Beulich wrote: > >>

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 16:14, wrote: > On 22/12/16 14:58, Jan Beulich wrote: > On 22.12.16 at 15:31, wrote: >> On 22.12.16 at 14:47, wrote: On 22/12/16 08:37, Jan Beulich wrote: > Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to > determine whether to install th

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Andrew Cooper
On 22/12/16 14:58, Jan Beulich wrote: On 22.12.16 at 15:31, wrote: On 22.12.16 at 14:47, wrote: On 22/12/16 08:37, Jan Beulich wrote: Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to determine whether to install the hook in the first place. Signed-off-by: Jan Beulich I am

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 15:31, wrote: On 22.12.16 at 14:47, wrote: >> On 22/12/16 08:37, Jan Beulich wrote: >>> Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to >>> determine whether to install the hook in the first place. >>> >>> Signed-off-by: Jan Beulich >> >> I am not so su

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
>>> On 22.12.16 at 14:47, wrote: > On 22/12/16 08:37, Jan Beulich wrote: >> Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to >> determine whether to install the hook in the first place. >> >> Signed-off-by: Jan Beulich > > I am not so sure about this. > > vmfunc is reachable in

Re: [Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Andrew Cooper
On 22/12/16 08:37, Jan Beulich wrote: Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to determine whether to install the hook in the first place. Signed-off-by: Jan Beulich I am not so sure about this. vmfunc is reachable in the instruction emulator on hardware which doesn't

[Xen-devel] [PATCH 2/2] x86/VMX: don't needlessly install VMFUNC emulation hook

2016-12-22 Thread Jan Beulich
Instead of checking cpu_has_vmx_vmfunc inside the hook, use it to determine whether to install the hook in the first place. Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2011,7 +2011,7 @@ static int vmx_vcpu_emulate_vmfunc(const int rc = X8