Re: [Xen-devel] [PATCH 2/2] libxl_internal: comment on domain userdata unlock function

2015-01-08 Thread Ian Campbell
On Wed, 2015-01-07 at 16:57 +, Wei Liu wrote: > > > diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c > > > index 9d8025d..a70214b 100644 > > > --- a/tools/libxl/libxl_internal.c > > > +++ b/tools/libxl/libxl_internal.c > > > @@ -458,6 +458,20 @@ out: > > > > > > void

Re: [Xen-devel] [PATCH 2/2] libxl_internal: comment on domain userdata unlock function

2015-01-07 Thread Wei Liu
On Wed, Jan 07, 2015 at 04:52:00PM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH 2/2] libxl_internal: comment on domain userdata > unlock function"): > > Discuss why we need to unlink file path before closes fd. > > Acked-by: Ian Jackson > subject to minor grammar complaint: > > Potential

Re: [Xen-devel] [PATCH 2/2] libxl_internal: comment on domain userdata unlock function

2015-01-07 Thread Ian Jackson
Wei Liu writes ("[PATCH 2/2] libxl_internal: comment on domain userdata unlock function"): > Discuss why we need to unlink file path before closes fd. Acked-by: Ian Jackson subject to minor grammar complaint: Potential backport candidate for 4.5.1 ? > diff --git a/tools/libxl/libxl_internal.c

[Xen-devel] [PATCH 2/2] libxl_internal: comment on domain userdata unlock function

2015-01-07 Thread Wei Liu
Discuss why we need to unlink file path before closes fd. Signed-off-by: Wei Liu Cc: Ian Campbell Cc: Ian Jackson --- tools/libxl/libxl_internal.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c index 9d8025d..a7