Wei Liu writes ("[PATCH 2/2] libxl_internal: comment on domain userdata unlock
function"):
> Discuss why we need to unlink file path before closes fd.
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
subject to minor grammar complaint:
Potential backport candidate for 4.5.1 ?
> diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c
> index 9d8025d..a70214b 100644
> --- a/tools/libxl/libxl_internal.c
> +++ b/tools/libxl/libxl_internal.c
> @@ -458,6 +458,20 @@ out:
>
> void libxl__unlock_domain_userdata(libxl__domain_userdata_lock *lock)
> {
> + /* It's important to unlink the file before closing fd to avoid
> + * such race (if close before unlink):
^^^^
"to avoid the following race". "Such" must refer to a thing which
precedes.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
