Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Olaf Hering
On Tue, Feb 03, Ian Campbell wrote: > Olof, you just removed the nul terminator used there AFAICT. At best > this means that the vgabios_copyright is printed twice. My bad. Will resend. Thanks for the review. Olaf ___ Xen-devel mailing list Xen-devel@

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:28, wrote: > On Tue, 2015-02-03 at 16:17 +, Jan Beulich wrote: >> >>> On 03.02.15 at 17:06, wrote: >> > On 03/02/15 15:54, Olaf Hering wrote: >> >> Including a timestamp into the binary makes it impossible to get >> >> reproducible binaries. Remove the timestamp because

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:17 +, Jan Beulich wrote: > >>> On 03.02.15 at 17:06, wrote: > > On 03/02/15 15:54, Olaf Hering wrote: > >> Including a timestamp into the binary makes it impossible to get > >> reproducible binaries. Remove the timestamp because it carries no > >> valuable info. > >> >

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:23 +, Andrew Cooper wrote: > On 03/02/15 16:18, Ian Campbell wrote: > > On Tue, 2015-02-03 at 16:06 +, Andrew Cooper wrote: > >> On 03/02/15 15:54, Olaf Hering wrote: > >>> Including a timestamp into the binary makes it impossible to get > >>> reproducible binaries.

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Andrew Cooper
On 03/02/15 16:18, Ian Campbell wrote: > On Tue, 2015-02-03 at 16:06 +, Andrew Cooper wrote: >> On 03/02/15 15:54, Olaf Hering wrote: >>> Including a timestamp into the binary makes it impossible to get >>> reproducible binaries. Remove the timestamp because it carries no >>> valuable info. >>>

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Ian Campbell
On Tue, 2015-02-03 at 16:06 +, Andrew Cooper wrote: > On 03/02/15 15:54, Olaf Hering wrote: > > Including a timestamp into the binary makes it impossible to get > > reproducible binaries. Remove the timestamp because it carries no > > valuable info. > > > > Signed-off-by: Olaf Hering > > Cc: I

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Jan Beulich
>>> On 03.02.15 at 17:06, wrote: > On 03/02/15 15:54, Olaf Hering wrote: >> Including a timestamp into the binary makes it impossible to get >> reproducible binaries. Remove the timestamp because it carries no >> valuable info. >> >> Signed-off-by: Olaf Hering >> Cc: Ian Jackson >> Cc: Stefano S

Re: [Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Andrew Cooper
On 03/02/15 15:54, Olaf Hering wrote: > Including a timestamp into the binary makes it impossible to get > reproducible binaries. Remove the timestamp because it carries no > valuable info. > > Signed-off-by: Olaf Hering > Cc: Ian Jackson > Cc: Stefano Stabellini > Cc: Ian Campbell > Cc: Wei Li

[Xen-devel] [PATCH 2/2] hvmloader: remove timestamp from vgabios

2015-02-03 Thread Olaf Hering
Including a timestamp into the binary makes it impossible to get reproducible binaries. Remove the timestamp because it carries no valuable info. Signed-off-by: Olaf Hering Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Wei Liu --- tools/firmware/vgabios/Makefile | 11 -