On Tue, 2015-02-03 at 16:06 +0000, Andrew Cooper wrote:
> On 03/02/15 15:54, Olaf Hering wrote:
> > Including a timestamp into the binary makes it impossible to get
> > reproducible binaries. Remove the timestamp because it carries no
> > valuable info.
> >
> > Signed-off-by: Olaf Hering <o...@aepfle.de>
> > Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com>
> > Cc: Ian Campbell <ian.campb...@citrix.com>
> > Cc: Wei Liu <wei.l...@citrix.com>
> 
> In this case, it would appear that the vgabios_date symbol is completely
> unused inside the binary.  Good riddance!

I think it is actually used because the string at vgabios_version
(deliberately) falls through.

Olof, you just removed the nul terminator used there AFAICT. At best
this means that the vgabios_copyright is printed twice.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to