Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-17 Thread Daniel De Graaf
On 06/17/2016 01:21 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jun 17, 2016 at 01:18:47PM -0400, Daniel De Graaf wrote: On 06/17/2016 01:14 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jun 17, 2016 at 01:04:01PM -0400, Daniel De Graaf wrote: On 06/17/2016 11:50 AM, Konrad Rzeszutek Wilk wrote: On T

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-17 Thread Konrad Rzeszutek Wilk
On Fri, Jun 17, 2016 at 01:18:47PM -0400, Daniel De Graaf wrote: > On 06/17/2016 01:14 PM, Konrad Rzeszutek Wilk wrote: > >On Fri, Jun 17, 2016 at 01:04:01PM -0400, Daniel De Graaf wrote: > >>On 06/17/2016 11:50 AM, Konrad Rzeszutek Wilk wrote: > >>>On Thu, Jun 09, 2016 at 10:47:15AM -0400, Daniel

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-17 Thread Daniel De Graaf
On 06/17/2016 01:14 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jun 17, 2016 at 01:04:01PM -0400, Daniel De Graaf wrote: On 06/17/2016 11:50 AM, Konrad Rzeszutek Wilk wrote: On Thu, Jun 09, 2016 at 10:47:15AM -0400, Daniel De Graaf wrote: Since FLASK is the only implementation of XSM hooks in Xen

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-17 Thread Konrad Rzeszutek Wilk
On Fri, Jun 17, 2016 at 01:04:01PM -0400, Daniel De Graaf wrote: > On 06/17/2016 11:50 AM, Konrad Rzeszutek Wilk wrote: > >On Thu, Jun 09, 2016 at 10:47:15AM -0400, Daniel De Graaf wrote: > >>Since FLASK is the only implementation of XSM hooks in Xen, using an > >>iterated initcall dispatch for set

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-17 Thread Daniel De Graaf
On 06/17/2016 11:50 AM, Konrad Rzeszutek Wilk wrote: On Thu, Jun 09, 2016 at 10:47:15AM -0400, Daniel De Graaf wrote: Since FLASK is the only implementation of XSM hooks in Xen, using an iterated initcall dispatch for setup is overly complex. Change this to As such, should the Kconfig file en

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-17 Thread Konrad Rzeszutek Wilk
On Thu, Jun 09, 2016 at 10:47:15AM -0400, Daniel De Graaf wrote: > Since FLASK is the only implementation of XSM hooks in Xen, using an > iterated initcall dispatch for setup is overly complex. Change this to As such, should the Kconfig file enable the FLASK by default? Or make the XSM entry have

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-09 Thread Daniel De Graaf
On 06/09/2016 12:11 PM, Jan Beulich wrote: On 09.06.16 at 16:47, wrote: Since FLASK is the only implementation of XSM hooks in Xen, using an iterated initcall dispatch for setup is overly complex. Change this to a direct function call to a globally visible function; if additional XSM hooks are

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-09 Thread Jan Beulich
>>> On 09.06.16 at 16:47, wrote: > Since FLASK is the only implementation of XSM hooks in Xen, using an > iterated initcall dispatch for setup is overly complex. Change this to > a direct function call to a globally visible function; if additional XSM > hooks are added in the future, a switching

Re: [Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-09 Thread Andrew Cooper
On 09/06/16 15:47, Daniel De Graaf wrote: > Since FLASK is the only implementation of XSM hooks in Xen, using an > iterated initcall dispatch for setup is overly complex. Change this to > a direct function call to a globally visible function; if additional XSM > hooks are added in the future, a sw

[Xen-devel] [PATCH 12/15] xen/xsm: remove .xsm_initcall.init section

2016-06-09 Thread Daniel De Graaf
Since FLASK is the only implementation of XSM hooks in Xen, using an iterated initcall dispatch for setup is overly complex. Change this to a direct function call to a globally visible function; if additional XSM hooks are added in the future, a switching mechanism will be needed regardless, and t