Re: [Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

2015-01-19 Thread David Vrabel
On 19/01/15 18:38, Stefano Stabellini wrote: > On Mon, 19 Jan 2015, David Vrabel wrote: >> On 19/01/15 17:49, Stefano Stabellini wrote: >>> On Mon, 19 Jan 2015, David Vrabel wrote: Unmapping may require sleeping and we unmap while holding priv->lock, so convert it to a mutex. >>> >>> It w

Re: [Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

2015-01-19 Thread Stefano Stabellini
On Mon, 19 Jan 2015, David Vrabel wrote: > On 19/01/15 17:49, Stefano Stabellini wrote: > > On Mon, 19 Jan 2015, David Vrabel wrote: > >> Unmapping may require sleeping and we unmap while holding priv->lock, so > >> convert it to a mutex. > > > > It would be useful to list in the commit message th

Re: [Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

2015-01-19 Thread David Vrabel
On 19/01/15 17:49, Stefano Stabellini wrote: > On Mon, 19 Jan 2015, David Vrabel wrote: >> Unmapping may require sleeping and we unmap while holding priv->lock, so >> convert it to a mutex. > > It would be useful to list in the commit message the operations that > might sleep and are currently cal

Re: [Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

2015-01-19 Thread Stefano Stabellini
On Mon, 19 Jan 2015, David Vrabel wrote: > Unmapping may require sleeping and we unmap while holding priv->lock, so > convert it to a mutex. It would be useful to list in the commit message the operations that might sleep and are currently called with the spinlock held. > Signed-off-by: David Vr

[Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

2015-01-19 Thread David Vrabel
Unmapping may require sleeping and we unmap while holding priv->lock, so convert it to a mutex. Signed-off-by: David Vrabel --- drivers/xen/gntdev.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen

[Xen-devel] [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex

2015-01-12 Thread David Vrabel
Unmapping may require sleeping and we unmap while holding priv->lock, so convert it to a mutex. Signed-off-by: David Vrabel --- drivers/xen/gntdev.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen