On Mon, 19 Jan 2015, David Vrabel wrote: > On 19/01/15 17:49, Stefano Stabellini wrote: > > On Mon, 19 Jan 2015, David Vrabel wrote: > >> Unmapping may require sleeping and we unmap while holding priv->lock, so > >> convert it to a mutex. > > > > It would be useful to list in the commit message the operations that > > might sleep and are currently called with the spinlock held. > > It's the next patch that introduces the sleeping, when we wait on the > completion for the async grant unmap to complete.
Ah! Makes sense. One thing to keep in mind is that mutex_lock can introduce a sleep itself. We need to make sure that all the call sites in gntdev.c are OK with it. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
