Re: [Xen-devel] [PATCH 1/3] libxl, xl: don't init/dispose when not necessary

2015-02-10 Thread Wei Liu
On Tue, Feb 10, 2015 at 10:54:47AM +, Ian Jackson wrote: > Wei Liu writes ("[PATCH 1/3] libxl, xl: don't init/dispose when not > necessary"): > > Functions like libxl__device_disk_from_xs_be and > > libxl_vdev_to_device_disk should not touch the disk struct passed in. > > It's caller's respons

Re: [Xen-devel] [PATCH 1/3] libxl, xl: don't init/dispose when not necessary

2015-02-10 Thread Ian Jackson
Wei Liu writes ("[PATCH 1/3] libxl, xl: don't init/dispose when not necessary"): > Functions like libxl__device_disk_from_xs_be and > libxl_vdev_to_device_disk should not touch the disk struct passed in. > It's caller's responsibility to do that. ... > Note that libxl_vdev_to_device_disk is a publi

Re: [Xen-devel] [PATCH 1/3] libxl, xl: don't init/dispose when not necessary

2015-02-09 Thread Wei Liu
On Mon, Feb 09, 2015 at 01:23:26PM +, Wei Liu wrote: > Er... The title should be > > "libxl, xl: don't init/dispose when not unnecessary" > -- Grrr... What was I thinking. The initial title was correct. Sorry for the noise and spam. __

Re: [Xen-devel] [PATCH 1/3] libxl, xl: don't init/dispose when not necessary

2015-02-09 Thread Wei Liu
Er... The title should be "libxl, xl: don't init/dispose when not unnecessary" -- ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/3] libxl, xl: don't init/dispose when not necessary

2015-02-09 Thread Wei Liu
Functions like libxl__device_disk_from_xs_be and libxl_vdev_to_device_disk should not touch the disk struct passed in. It's caller's responsibility to do that. This leads to some changes to the caller to prepare the disk struct. Note that libxl_vdev_to_device_disk is a public API so a macro is de