Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 15:12 +, Julien Grall wrote: > Hi Ian, > > On 24/03/2015 14:20, Ian Campbell wrote: > > @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, > > break; > > default: > > { > > -#ifndef NDEBUG > > struct hsr_cp64 c

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Julien Grall
Hi Jan, On 24/03/2015 15:31, Jan Beulich wrote: On 24.03.15 at 16:12, wrote: Hi Ian, On 24/03/2015 14:20, Ian Campbell wrote: @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, break; default: { -#ifndef NDEBUG struct hsr_cp64

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Jan Beulich
>>> On 24.03.15 at 16:12, wrote: > Hi Ian, > > On 24/03/2015 14:20, Ian Campbell wrote: >> @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, >> break; >> default: >> { >> -#ifndef NDEBUG >> struct hsr_cp64 cp64 = hsr.cp64; >> >>

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Julien Grall
Hi Ian, On 24/03/2015 14:20, Ian Campbell wrote: @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, break; default: { -#ifndef NDEBUG struct hsr_cp64 cp64 = hsr.cp64; gdprintk(XENLOG_ERR, @@ -1718,7 +1715,6 @@ static vo

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Ian Campbell
On Fri, 2015-03-20 at 15:12 +, Jan Beulich wrote: > ... and convert several gdprintk()-s to it, as the next patch will make > them no-ops in non-debug builds. > > Note that as a non-debug facility this does not print file name and > line number of the origin, to people are expected to use mean

[Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-20 Thread Jan Beulich
... and convert several gdprintk()-s to it, as the next patch will make them no-ops in non-debug builds. Note that as a non-debug facility this does not print file name and line number of the origin, to people are expected to use meaningful and easily distinguishable messages (i.e. just like with