Re: [Xen-devel] [PATCH 06/14] fuzz/x86_emulate: Implement dread() and davail()

2017-09-25 Thread George Dunlap
On Fri, Aug 25, 2017 at 6:45 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> Rather than open-coding the "read" from the input file. >> >> Signed-off-by: George Dunlap > > This patch fills me with dread. > > How about data_read() and data_available() which are slightly more

Re: [Xen-devel] [PATCH 06/14] fuzz/x86_emulate: Implement dread() and davail()

2017-09-14 Thread George Dunlap
On Fri, Aug 25, 2017 at 6:45 PM, Andrew Cooper wrote: > On 25/08/17 17:43, George Dunlap wrote: >> Rather than open-coding the "read" from the input file. >> >> Signed-off-by: George Dunlap > > This patch fills me with dread. > > How about data_read() and data_available() which are slightly more

Re: [Xen-devel] [PATCH 06/14] fuzz/x86_emulate: Implement dread() and davail()

2017-08-25 Thread Andrew Cooper
On 25/08/17 17:43, George Dunlap wrote: > Rather than open-coding the "read" from the input file. > > Signed-off-by: George Dunlap This patch fills me with dread. How about data_read() and data_available() which are slightly more descriptive? Also, both should be using bool rather than int. ~A

[Xen-devel] [PATCH 06/14] fuzz/x86_emulate: Implement dread() and davail()

2017-08-25 Thread George Dunlap
Rather than open-coding the "read" from the input file. Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Wei Liu CC: Andrew Cooper CC: Jan Beulich --- tools/fuzz/x86_instruction_emulator/fuzz-emul.c | 31 ++--- 1 file changed, 22 insertions(+), 9 deletions(-) diff --