On Fri, Aug 25, 2017 at 6:45 PM, Andrew Cooper <andrew.coop...@citrix.com> wrote: > On 25/08/17 17:43, George Dunlap wrote: >> Rather than open-coding the "read" from the input file. >> >> Signed-off-by: George Dunlap <george.dun...@citrix.com> > > This patch fills me with dread. > > How about data_read() and data_available() which are slightly more > descriptive? > > Also, both should be using bool rather than int.
I'm happy to do both; I was just waiting for comments on the rest of the series before resending. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel