Re: [Xen-devel] [PATCH] xl: don't print out uninitialised rc

2015-11-04 Thread Wei Liu
On Wed, Nov 04, 2015 at 11:23:29AM +, Ian Campbell wrote: > On Wed, 2015-11-04 at 11:15 +, Wei Liu wrote: > > In 5b725e56 (xl: improve return and exit codes of vcpu related > > functions), the return value of libxl_cpu_bitmap_alloc was not stored in > > rc anymore. Yet the subsequent fprint

Re: [Xen-devel] [PATCH] xl: don't print out uninitialised rc

2015-11-04 Thread Ian Campbell
On Wed, 2015-11-04 at 11:15 +, Wei Liu wrote: > In 5b725e56 (xl: improve return and exit codes of vcpu related > functions), the return value of libxl_cpu_bitmap_alloc was not stored in > rc anymore. Yet the subsequent fprintf still used that. > > While it is trivial to reinstate the original

[Xen-devel] [PATCH] xl: don't print out uninitialised rc

2015-11-04 Thread Wei Liu
In 5b725e56 (xl: improve return and exit codes of vcpu related functions), the return value of libxl_cpu_bitmap_alloc was not stored in rc anymore. Yet the subsequent fprintf still used that. While it is trivial to reinstate the original implementation, xl's caller has no idea what a libxl error c