Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-18 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 18:02:28 + > Since vzalloc can be failed in memory pressure, > writes -ENOMEM to xenstore to indicate error. > > Signed-off-by: Insu Yun Applied. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lis

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Insu Yun
For me, it seems more consistent using xen_bus_dev_fatal(); return; Because other codes also use them. If you want to use goto, then feel free to make a patch for this issue. On Fri, Oct 16, 2015 at 5:40 AM, David Vrabel wrote: > On 16/10/15 10:05, Wei Liu wrote: > > On Thu, Oct 15, 2015 at 02

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread David Vrabel
On 16/10/15 10:05, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: >> I changed patch with valid format. >> >> On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: >> >>> Since vzalloc can be failed in memory pressure, >>> writes -ENOMEM to xenstore to indicate error. >>> >>

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Fri, Oct 16, 2015 at 10:05:21AM +0100, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > > I changed patch with valid format. > > > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > > > Since vzalloc can be failed in memory pressure, > > > writes -ENOMEM to x

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-16 Thread Wei Liu
On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > I changed patch with valid format. > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > Since vzalloc can be failed in memory pressure, > > writes -ENOMEM to xenstore to indicate error. > > > > Signed-off-by: Insu Yun > > --- > >

[Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-15 Thread Insu Yun
Since vzalloc can be failed in memory pressure, writes -ENOMEM to xenstore to indicate error. Signed-off-by: Insu Yun --- drivers/net/xen-netback/xenbus.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 929a6e7..

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-15 Thread Insu Yun
I changed patch with valid format. On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > writes -ENOMEM to xenstore to indicate error. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 6 ++ > 1 file changed, 6 insertions(