For me, it seems more consistent using xen_bus_dev_fatal(); return;
Because other codes also use them.
If you want to use goto, then feel free to make a patch for this issue.
On Fri, Oct 16, 2015 at 5:40 AM, David Vrabel <david.vra...@citrix.com>
wrote:
> On 16/10/15 10:05, Wei Liu wrote:
> > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote:
> >> I changed patch with valid format.
> >>
> >> On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun <wuni...@gmail.com> wrote:
> >>
> >>> Since vzalloc can be failed in memory pressure,
> >>> writes -ENOMEM to xenstore to indicate error.
> >>>
> >>> Signed-off-by: Insu Yun <wuni...@gmail.com>
> >>> ---
> >>> drivers/net/xen-netback/xenbus.c | 6 ++++++
> >>> 1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/drivers/net/xen-netback/xenbus.c
> >>> b/drivers/net/xen-netback/xenbus.c
> >>> index 929a6e7..56ebd82 100644
> >>> --- a/drivers/net/xen-netback/xenbus.c
> >>> +++ b/drivers/net/xen-netback/xenbus.c
> >>> @@ -788,6 +788,12 @@ static void connect(struct backend_info *be)
> >>> /* Use the number of queues requested by the frontend */
> >>> be->vif->queues = vzalloc(requested_num_queues *
> >>> sizeof(struct xenvif_queue));
> >>> + if (!be->vif->queues) {
> >>> + xenbus_dev_fatal(dev, -ENOMEM,
> >>> + "allocating queues");
> >>> + return;
> >>>
> >>
> >> I didn't use goto err, because another error handling is not required
> >>
> >
> > It's recommended in kernel coding style to use "goto" style error
> > handling. I personally prefer that to arbitrary return in function body,
> > too.
> >
> > It's not a matter of whether another error handling is required or not,
> > it's about cleaner code that is easy to reason about and consistent
> > coding style.
>
> Using xenbus_dev_fatal(); return; throughout would be consistent and
> easy to reason about.
>
> Also, the goto err path should raise a fatal error (instead of
> disconnecting). I also note that failures in the xen_net_read_rate(),
> xen_register_watchers() and read_xenbus_vif_flags() are also not handled.
>
> David
>
--
Regards
Insu Yun
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
