Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

Hello, On 04/02/2015 15:13, Ian Campbell wrote: On Mon, 2015-02-02 at 20:03 +0200, Denis Drozdov wrote: From: denys drozdov Make Credit2 and RT schedulers to run on arm platform context_saved should be deferred on ARM after IRQs enabled A better subject+message would be: xen/arm:

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Wed, 2015-02-04 at 15:13 +, Ian Campbell wrote: > On Mon, 2015-02-02 at 20:03 +0200, Denis Drozdov wrote: > > From: denys drozdov > > > > Make Credit2 and RT schedulers to run on arm platform > > context_saved should be deferred on ARM after IRQs enabled > > A better subject+message would

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Mon, 2015-02-02 at 20:03 +0200, Denis Drozdov wrote: > From: denys drozdov > > Make Credit2 and RT schedulers to run on arm platform > context_saved should be deferred on ARM after IRQs enabled A better subject+message would be: xen/arm: Call context_saved() with interrupts enabled d

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Wed, 2015-02-04 at 15:04 +, Stefano Stabellini wrote: > On Mon, 2 Feb 2015, Julien Grall wrote: > > On 02/02/15 12:16, Ian Campbell wrote: > > > On Mon, 2015-02-02 at 11:40 +, Jan Beulich wrote: > > > On 02.02.15 at 12:14, wrote: > > >>> On Mon, 2015-02-02 at 12:49 +0200, Denys Droz

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Mon, 2 Feb 2015, Julien Grall wrote: > On 02/02/15 12:16, Ian Campbell wrote: > > On Mon, 2015-02-02 at 11:40 +, Jan Beulich wrote: > > On 02.02.15 at 12:14, wrote: > >>> On Mon, 2015-02-02 at 12:49 +0200, Denys Drozdov wrote: > The issue observed on credit2 scheduler is similar to

[Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

From: denys drozdov Make Credit2 and RT schedulers to run on arm platform context_saved should be deferred on ARM after IRQs enabled Signed-off-by: denys drozdov --- xen/arch/arm/domain.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

>>> On 02.02.15 at 13:16, wrote: > On Mon, 2015-02-02 at 11:40 +, Jan Beulich wrote: >> X86 calls context_saved() before >> schedule_tail() and has no need for IRQs to be disabled after >> __context_switch() returned. > > In fact from the comment ("...which may fault...") I think it requires

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Mon, 2015-02-02 at 12:59 +, Julien Grall wrote: > On 02/02/15 12:16, Ian Campbell wrote: > > On Mon, 2015-02-02 at 11:40 +, Jan Beulich wrote: > > On 02.02.15 at 12:14, wrote: > >>> On Mon, 2015-02-02 at 12:49 +0200, Denys Drozdov wrote: > The issue observed on credit2 schedule

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On 02/02/15 12:16, Ian Campbell wrote: > On Mon, 2015-02-02 at 11:40 +, Jan Beulich wrote: > On 02.02.15 at 12:14, wrote: >>> On Mon, 2015-02-02 at 12:49 +0200, Denys Drozdov wrote: The issue observed on credit2 scheduler is similar to the rt scheduler on arm platform. The root c

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Mon, 2015-02-02 at 11:40 +, Jan Beulich wrote: > >>> On 02.02.15 at 12:14, wrote: > > On Mon, 2015-02-02 at 12:49 +0200, Denys Drozdov wrote: > >> The issue observed on credit2 scheduler is similar to the rt scheduler > >> on arm platform. The root cause is that interrupts are disabled in t

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

>>> On 02.02.15 at 12:14, wrote: > On Mon, 2015-02-02 at 12:49 +0200, Denys Drozdov wrote: >> The issue observed on credit2 scheduler is similar to the rt scheduler >> on arm platform. The root cause is that interrupts are disabled in the >> beginning of arm context_switch, thus spin_lock_irq is f

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Mon, 2015-02-02 at 12:49 +0200, Denys Drozdov wrote: Please don't top post. > The issue observed on credit2 scheduler is similar to the rt scheduler > on arm platform. The root cause is that interrupts are disabled in the > beginning of arm context_switch, thus spin_lock_irq is failing in > AS

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

Hi Ian, The issue observed on credit2 scheduler is similar to the rt scheduler on arm platform. The root cause is that interrupts are disabled in the beginning of arm context_switch, thus spin_lock_irq is failing in ASSERT(local_irq_is_enabled()). I propose to change both credit2 and rt scheduler

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On Fri, 2015-01-30 at 18:19 +0200, Denys Drozdov wrote: > since context_save executed right from IRQ level. The arm interrupt > handling differs from x86. ARM is handling context_saved with IRQ > disabled in CPSR, though x86 has IRQs on. Thus it is failing on ASSERT > inside spin_lock_irq when ru

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On 30/01/15 16:19, Denys Drozdov wrote: > Julien, > > The details of this issue can be found in the current mailing list. > Please have a look > athttp://lists.xen.org/archives/html/xen-devel/2014-09/msg04250.html > . > This is ex

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

Julien, The details of this issue can be found in the current mailing list. Please have a look at http://lists.xen.org/archives/html/xen-devel/2014-09/msg04250.html. This is exactly the same behaviour we are observing when running on our arm setup. The fix changes spin_lock_irq/spin_unlock_irq to

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On 30/01/15 15:56, Andrew Cooper wrote: > On 30/01/15 15:46, Julien Grall wrote: >> Hello Denys, >> >> On 30/01/15 15:40, Denis Drozdov wrote: >>> From: denys drozdov >>> >>> Update RT scheduler to run on arm platform >> You need to give more background of the problem (i.e why you have to >> disab

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

On 30/01/15 15:46, Julien Grall wrote: > Hello Denys, > > On 30/01/15 15:40, Denis Drozdov wrote: >> From: denys drozdov >> >> Update RT scheduler to run on arm platform > You need to give more background of the problem (i.e why you have to > disable the IRQ on ARM). > > As the scheduler is common

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

Hello Denys, On 30/01/15 15:40, Denis Drozdov wrote: > From: denys drozdov > > Update RT scheduler to run on arm platform You need to give more background of the problem (i.e why you have to disable the IRQ on ARM). As the scheduler is common with x86, I would expect the problem is also happen

[Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

From: denys drozdov Update RT scheduler to run on arm platform Signed-off-by: denys drozdov --- xen/common/sched_rt.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index e70d6c7..5fcc205 100644 --- a/xen/common/sched_r

Re: [Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

>>> On 30.01.15 at 13:30, wrote: > From: denys drozdov There's a description missing here of _what_ (case) you are fixing. > Change-Id: I9b315f213775b8410fe75cd96968dcb213ea287b And the purpose of this line is unclear. > --- a/xen/common/sched_rt.c > +++ b/xen/common/sched_rt.c > @@ -1010,8 +

[Xen-devel] [PATCH] xen/arm: Fix rtds scheduler for arm

From: denys drozdov Change-Id: I9b315f213775b8410fe75cd96968dcb213ea287b Signed-off-by: denys drozdov --- xen/common/sched_rt.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index e70d6c7..1ab0a62 100644 --- a/xen/com