Re: [Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

2016-02-15 Thread Jan Beulich
>>> On 15.02.16 at 13:51, wrote: > On 15/02/16 11:57, Jan Beulich wrote: >> ... and hence the respective {read,write}_msr() hook parameter doesn't >> need to be "unsigned long". >> >> Signed-off-by: Jan Beulich > > I would suggest uint32_t instead (being more architecturally > self-documenting),

Re: [Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

2016-02-15 Thread Andrew Cooper
On 15/02/16 11:57, Jan Beulich wrote: > ... and hence the respective {read,write}_msr() hook parameter doesn't > need to be "unsigned long". > > Signed-off-by: Jan Beulich I would suggest uint32_t instead (being more architecturally self-documenting), but either way, Reviewed-by: Andrew Cooper

[Xen-devel] [PATCH] x86emul: MSR indexes are only 32 bits wide

2016-02-15 Thread Jan Beulich
... and hence the respective {read,write}_msr() hook parameter doesn't need to be "unsigned long". Signed-off-by: Jan Beulich --- a/xen/arch/x86/hvm/emulate.c +++ b/xen/arch/x86/hvm/emulate.c @@ -966,7 +966,7 @@ static int hvmemul_write_io_discard( } static int hvmemul_write_msr_discard( -